Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make StandardReadable _read_signals, _configuration_signals and _read_uncached_signals publically accessible #196

Closed
callumforrester opened this issue Apr 11, 2024 · 2 comments
Labels
good first issue Good for newcomers hackathon Good issues for the upcoming bluesky hackathon

Comments

@callumforrester
Copy link
Contributor

Required as short-term solution for #192, these attributes should be accessible from other devices. I suggest using a read-only property e.g.

class StandardReadable:
    ...
    @property
    def read_signals(self) -> List[SignalR]:
        return self._read_signals

Ditto for the others.

Acceptance Critera

  • Can call .read_signals, .configuration_signals and .read_uncached_signals on a StandardReadable
  • Tests to prove this/prevent regression
@callumforrester callumforrester added the hackathon Good issues for the upcoming bluesky hackathon label Apr 11, 2024
@callumforrester callumforrester added the good first issue Good for newcomers label Apr 12, 2024
@coretl
Copy link
Collaborator

coretl commented Apr 15, 2024

I would prefer to make the decision on #192 first, as we may not require it if we choose a different route there...

@coretl
Copy link
Collaborator

coretl commented May 1, 2024

Closed by #240

@coretl coretl closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hackathon Good issues for the upcoming bluesky hackathon
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants