Make alt text scrollable on native #5642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
hailey/scrollable-alt-lightbox - social-app PR #5642
Render
Destroyed
estrattonbailey
approved these changes
Oct 7, 2024
estrattonbailey
added a commit
that referenced
this pull request
Oct 8, 2024
* origin/main: (267 commits) Nicer error message for disabled quotes (#5644) Update neue nux date (#5643) Make alt text scrollable on native (#5642) Move remaining composer state into reducer (#5623) Fetch link previews from RQ (#5608) Use composer state as source of truth for embeds/links on publish (#5606) Update Indonesian translation (#5316) [Video] Add dimension info to share intent pt.2 (#5640) [Video] Prevent screen from dimming while in full screen (#5637) [Video] Add dimension info to share intent (#5639) [Video] Revert safari hackfix (#5367) Swipeable to delete chat, custom swipeable (#5614) equal spacing on displayname/handle (#5636) Update Japanese translation (#5374) Update catalana messages.po (#5380) Update and inconsistency fixes to pt-br translation (#5436) Tweak #5522 (#5635) Update Korean localization (#5401) Update Chinese localization (#5433) Add Cantonese Localization (#5479) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When users have larger sized font settings, some big alt text blocks can be made unreadable since they do not scroll. Here we're adding that ability when you expand the alt text portion of the lightbox.
Test Plan
Android
Screen.Recording.2024-10-07.at.4.54.08.PM.mov
iOS
RocketSim_Recording_iPhone_16_Pro_6.3_2024-10-07_16.57.20.mp4