Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Video] Add dimension info to share intent pt.2 #5640

Merged
merged 6 commits into from
Oct 7, 2024

Conversation

haileyok
Copy link
Contributor

@haileyok haileyok commented Oct 7, 2024

Follow up to #5639. Noticed during testing that I forgot to run yarn update-extensions after working on this, so a few iOS changes did not land. This just adds those fixes.

@arcalinea arcalinea temporarily deployed to hailey/add-dimensions-share-2 - social-app PR #5640 October 7, 2024 22:28 — with Render Destroyed
@haileyok haileyok changed the title add dimensions to response on ios [Video] Add dimension info to share intent pt.2 Oct 7, 2024
@arcalinea arcalinea temporarily deployed to hailey/add-dimensions-share-2 - social-app PR #5640 October 7, 2024 22:29 — with Render Destroyed
@haileyok haileyok merged commit 80e25b3 into main Oct 7, 2024
5 of 6 checks passed
@haileyok haileyok deleted the hailey/add-dimensions-share-2 branch October 7, 2024 22:32
estrattonbailey added a commit that referenced this pull request Oct 8, 2024
* origin/main: (267 commits)
  Nicer error message for disabled quotes (#5644)
  Update neue nux date (#5643)
  Make alt text scrollable on native (#5642)
  Move remaining composer state into reducer (#5623)
  Fetch link previews from RQ (#5608)
  Use composer state as source of truth for embeds/links on publish (#5606)
  Update Indonesian translation (#5316)
  [Video] Add dimension info to share intent pt.2 (#5640)
  [Video] Prevent screen from dimming while in full screen (#5637)
  [Video] Add dimension info to share intent (#5639)
  [Video] Revert safari hackfix (#5367)
  Swipeable to delete chat, custom swipeable (#5614)
  equal spacing on displayname/handle (#5636)
  Update Japanese translation (#5374)
  Update catalana messages.po (#5380)
  Update and inconsistency fixes to pt-br translation (#5436)
  Tweak #5522 (#5635)
  Update Korean localization (#5401)
  Update Chinese localization (#5433)
  Add Cantonese Localization (#5479)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants