Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to remove quoted post in composer #3670

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Apr 23, 2024

Adds an X in the top corner of the quote post. Does not apply to quotes added via the repost menu, should only be for pasted in quotes.

It's small, to keep it out of the way, but it has a generous hitslop

Screenshot 2024-04-24 at 00 12 20

Test plan

  1. Paste in link and try clearing it
  2. Observe you can't clear a quote added via repost menu
  3. Paste in a link on top of a repost menu quote and see it is clearable

Copy link

render bot commented Apr 23, 2024

Copy link

Old size New size Diff
6.45 MB 6.45 MB 578 B (0.01%)

@gaearon gaearon merged commit 0847e27 into main Apr 23, 2024
6 checks passed
estrattonbailey added a commit that referenced this pull request Apr 23, 2024
* origin/main: (47 commits)
  Add option to remove quoted post in composer (#3670)
  Add border radius to GIF loading state (#3669)
  use mp4 over webm (#3666)
  Release 1.79 (#3661)
  Update Japanese translation (#3656)
  [Statsig] Add test gates and events (#3659)
  Quick fix to ensure disable 2fa dialog adjusts to keyboard (#3658)
  Email auth factor (#3602)
  GIF Viewer (#3605)
  Ungate profile scroll fix (#3655)
  rm country param (#3653)
  [GIFs] Remove consent flow (#3652)
  [GIFs] Replace GIPHY with Tenor (#3651)
  properly close the switch account dialog (#3558)
  [GIFs] Reset scroll on query change (#3642)
  Update French translations (#3644)
  [GIFs] Add error boundary to GIF picker (#3643)
  Revert "Add layout transitions to the composer photo gallery on iOS (#3609)" (#3649)
  Update Finnish translations  (#3630)
  Update Japanese translations (#3632)
  ...
tkusano added a commit to tkusano/social-app that referenced this pull request Apr 25, 2024
(accessibilityLabel & accessibilityHint)
cf. bluesky-social#3670
pfrazee pushed a commit that referenced this pull request Apr 29, 2024
* Remove old old onboarding related entries

cf. #3674

* Update Japanese translation

(accessibilityLabel & accessibilityHint)
cf. #3670

* Update Japanese translation

* Fix Japanase translation related to block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants