Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GIFs] Reset scroll on query change #3642

Merged
merged 3 commits into from
Apr 22, 2024
Merged

[GIFs] Reset scroll on query change #3642

merged 3 commits into from
Apr 22, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Apr 22, 2024

Resets the GIF picker list to the top when the query changes. I found that triggering an effect on the debounced search string value was most reliable.

Also, this PR closes the keyboard on swipe

Copy link

render bot commented Apr 22, 2024

@mozzius mozzius requested a review from gaearon April 22, 2024 12:58
Copy link

github-actions bot commented Apr 22, 2024

Old size New size Diff
6.44 MB 6.44 MB 34 B (0.00%)

@gaearon gaearon merged commit f49d73d into main Apr 22, 2024
6 checks passed
@gaearon gaearon deleted the samuel/gif-picker-scroll branch April 22, 2024 21:18
estrattonbailey added a commit that referenced this pull request Apr 23, 2024
* origin/main: (47 commits)
  Add option to remove quoted post in composer (#3670)
  Add border radius to GIF loading state (#3669)
  use mp4 over webm (#3666)
  Release 1.79 (#3661)
  Update Japanese translation (#3656)
  [Statsig] Add test gates and events (#3659)
  Quick fix to ensure disable 2fa dialog adjusts to keyboard (#3658)
  Email auth factor (#3602)
  GIF Viewer (#3605)
  Ungate profile scroll fix (#3655)
  rm country param (#3653)
  [GIFs] Remove consent flow (#3652)
  [GIFs] Replace GIPHY with Tenor (#3651)
  properly close the switch account dialog (#3558)
  [GIFs] Reset scroll on query change (#3642)
  Update French translations (#3644)
  [GIFs] Add error boundary to GIF picker (#3643)
  Revert "Add layout transitions to the composer photo gallery on iOS (#3609)" (#3649)
  Update Finnish translations  (#3630)
  Update Japanese translations (#3632)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants