properly close the switch account dialog #3558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Revert "properly check if the ref is null" This reverts commit 8f563808a5d39389b0bc47a31e73cd147d1e7e8b. properly check if the ref is null ensure dialog is closed on unmount
haileyok
force-pushed
the
hailey/switch-acc-dialog-fix
branch
from
73adda3 to
a48548f
Compare
This reverts commit a48548f.
|
Your Render PR Server URL is https://social-app-pr-3558.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cojd6hmv3ddc73audgog. |
gaearon
approved these changes
Apr 22, 2024
estrattonbailey
added a commit
that referenced
this pull request
Apr 23, 2024
* origin/main: (47 commits) Add option to remove quoted post in composer (#3670) Add border radius to GIF loading state (#3669) use mp4 over webm (#3666) Release 1.79 (#3661) Update Japanese translation (#3656) [Statsig] Add test gates and events (#3659) Quick fix to ensure disable 2fa dialog adjusts to keyboard (#3658) Email auth factor (#3602) GIF Viewer (#3605) Ungate profile scroll fix (#3655) rm country param (#3653) [GIFs] Remove consent flow (#3652) [GIFs] Replace GIPHY with Tenor (#3651) properly close the switch account dialog (#3558) [GIFs] Reset scroll on query change (#3642) Update French translations (#3644) [GIFs] Add error boundary to GIF picker (#3643) Revert "Add layout transitions to the composer photo gallery on iOS (#3609)" (#3649) Update Finnish translations (#3630) Update Japanese translations (#3632) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
As we discovered in #3451, we need to first close the dialog before running the callback. I.e.
Ideally we should just always remember to do this and would never have a case of it not working, but there are situations where an unmount might occur before we are ever even able to call
control.close(). In those cases, we should call thecontrol.close()when the Dialog component unmounts.Test Plan
On Android, I have tested switching accounts before and after this change. Before, there would be a brief "freeze" before the dialog disappeared. Now, the dialog closes and then the account switches. The back button works now, whereas before it did not. Recording on an iPhone simulator because recording on an android simulator is 👎
Before
After