First pass at a session handler #1850

estrattonbailey · 2023-11-09T01:14:38Z

No description provided.

estrattonbailey · 2023-11-09T18:07:24Z

src/state/persisted/legacy.ts

@@ -35,7 +35,7 @@ type LegacySchema = {
    description: string
    avatar: string
  }
-  onboarding: {
+  onboarding?: {


Migration was failing bc we've removed these mobx models now. We should be careful going forward to make sure we can resume from a partial migration. So far so good, and in the next release with these changes, it will be a full migration, so probably not a big deal...

estrattonbailey · 2023-11-09T18:07:46Z

src/state/persisted/schema.ts

+  // displayName: z.string().optional(),
+  // aviUrl: z.string().optional(),


Thinking that anything NOT returned from session response should be loaded with RQ

We want to have this information in logged out screens and in the account selector

I guess we can fetch every time

estrattonbailey · 2023-11-09T18:08:30Z

src/state/persisted/schema.ts

-  handle: z.string().optional(),
-  displayName: z.string().optional(),
-  aviUrl: z.string().optional(),
+  handle: z.string(),


Handle is returned from session, and the resumeSession method actually requires it in types but still works without it

estrattonbailey · 2023-11-09T18:09:23Z

src/state/shell/onboarding.tsx

+      const next = persisted.get('onboarding').step
+      // TODO we've introduced a footgun
+      if (state.step !== next) {


Hehe this was cyclically updating in the background. Wonder if we can protect against this better at a higher level?

mm that was on me, I think the only way to solve it is to avoid fires in response to this event -- the type: set needs a silent: true param

estrattonbailey · 2023-11-09T18:09:39Z

src/view/com/auth/login/Login.tsx

+      await login({
+        service: serviceUrl,
+        identifier: fullIdent,
+        password,
+      })
      await store.session.login({
        service: serviceUrl,
        identifier: fullIdent,


Just dual-booting rn

estrattonbailey · 2023-11-09T18:09:55Z

src/view/screens/Settings.tsx

@@ -303,10 +307,11 @@ export const SettingsScreen = withAuthRequired(
              accessibilityLabel={`Switch to ${account.handle}`}
              accessibilityHint="Switches the account you are logged in to">
              <View style={styles.avi}>
-                <UserAvatar size={40} avatar={account.aviUrl} />
+                {/*<UserAvatar size={40} avatar={account.aviUrl} />*/}


Need to get RQ in here

pfrazee

This is looking like the right approach to me

pfrazee · 2023-11-09T19:56:37Z

src/state/persisted/schema.ts

+  // displayName: z.string().optional(),
+  // aviUrl: z.string().optional(),


We want to have this information in logged out screens and in the account selector

src/App.web.tsx

pfrazee · 2023-11-09T20:02:30Z

src/state/session/index.tsx

+    [upsertAccount],
+  )
+
+  const logout = React.useCallback<ApiContext['logout']>(async () => {


We should send the delete session request, right?

Is there a method like this? I don't see one. Atm no, we just clear the tokens from memory and storage

https://github.com/bluesky-social/atproto/blob/main/lexicons/com/atproto/server/deleteSession.json

can do this later though

pfrazee · 2023-11-09T20:07:18Z

src/state/shell/onboarding.tsx

+      const next = persisted.get('onboarding').step
+      // TODO we've introduced a footgun
+      if (state.step !== next) {


mm that was on me, I think the only way to solve it is to avoid fires in response to this event -- the type: set needs a silent: true param

pfrazee · 2023-11-09T20:08:19Z

src/state/persisted/schema.ts

+  // displayName: z.string().optional(),
+  // aviUrl: z.string().optional(),


I guess we can fetch every time

gaearon

seems good overall

src/App.web.tsx

src/state/session/index.tsx

gaearon · 2023-11-09T22:18:06Z

src/state/session/index.tsx

  )

+  React.useEffect(() => {
+    persisted.write('session', {


Note you probably don't want to do this after first render. So maybe:

Keep a wrapper that sets a dirty flag in a ref

In the Effect, if the dirty flag is true, persist and unset the flag.

* origin: Fix tab alignment on the web (#1857) Show tabs when swiping feeds (#1856) Sync top/bottom bar disappearance to the scroll (#1855) Hotfix internationalization on mobile (#1854) Internationalization & localization (#1822) Hide/show header and footer without re-renders, take two (#1849)

pfrazee

Going to go ahead and merge so others can build off this. More will come in followup PRs. Good work @estrattonbailey

estrattonbailey added 14 commits November 8, 2023 19:14

First pass at a session handler

6aaa6fe

TODOs

fc66a4c

Fix recursion

9fe16cc

Couple more things

8282970

Add back resume session concept

2322593

Handle ready

279b4d6

Cleanup of initial loading states

2c843af

Handle init failure

c1b46c8

Cleanup

7ee624e

Remove account

ece5b82

Add updateCurrentAccount

692e8e2

Remove log

25fb2b5

Cleanup

a5cac59

Integrate removeAccount

c1d7ac8

estrattonbailey commented Nov 9, 2023

View reviewed changes

pfrazee reviewed Nov 9, 2023

View reviewed changes

gaearon reviewed Nov 9, 2023

View reviewed changes

src/App.web.tsx Show resolved Hide resolved

src/state/session/index.tsx Outdated Show resolved Hide resolved

estrattonbailey added 3 commits November 9, 2023 15:44

Add hasSession

75905a5

Add to App.native, harden migration

ea954bb

Use effect to persist data

c673747

gaearon reviewed Nov 9, 2023

View reviewed changes

estrattonbailey marked this pull request as ready for review November 9, 2023 22:24

pfrazee approved these changes Nov 9, 2023

View reviewed changes

pfrazee merged commit 625cbc4 into main Nov 9, 2023
4 checks passed

pfrazee deleted the eric/session-hook branch November 9, 2023 23:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

First pass at a session handler #1850

First pass at a session handler #1850

estrattonbailey commented Nov 9, 2023

estrattonbailey Nov 9, 2023

estrattonbailey Nov 9, 2023

pfrazee Nov 9, 2023

pfrazee Nov 9, 2023

estrattonbailey Nov 9, 2023

estrattonbailey Nov 9, 2023

pfrazee Nov 9, 2023

estrattonbailey Nov 9, 2023

estrattonbailey Nov 9, 2023

pfrazee left a comment

pfrazee Nov 9, 2023

pfrazee Nov 9, 2023

estrattonbailey Nov 9, 2023

pfrazee Nov 9, 2023

pfrazee Nov 9, 2023

pfrazee Nov 9, 2023

gaearon left a comment

gaearon Nov 9, 2023

pfrazee left a comment

		// displayName: z.string().optional(),
		// aviUrl: z.string().optional(),

First pass at a session handler #1850

First pass at a session handler #1850

Conversation

estrattonbailey commented Nov 9, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pfrazee left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gaearon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pfrazee left a comment

Choose a reason for hiding this comment