Hide/show header and footer without re-renders, take two #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
commented
Nov 9, 2023
| const setContext = React.createContext<SetContext>((_: boolean) => {}) | ||
|
|
||
| export function Provider({children}: React.PropsWithChildren<{}>) { | ||
| const [state, setState] = React.useState(false) | ||
| const mode = useSharedValue(false) | ||
| const setMode = React.useCallback( |
There was a problem hiding this comment.
I kept the setter so that writes are centralized and easy to trace. Technically code can screw around with .value but we can catch that in review.
gaearon
commented
Nov 9, 2023
| style={[ | ||
| styles.prompt, | ||
| fabMinimalShellTransform, |
There was a problem hiding this comment.
We could rename this since this isn't technically FAB, I think it's fine though.
gaearon
commented
Nov 9, 2023
| @@ -38,7 +38,6 @@ export const FeedsTabBar = observer(function FeedsTabBarImpl( | |||
| pal.border, | |||
| styles.tabBar, | |||
| headerMinimalShellTransform, | |||
| minimalShellMode && styles.disabled, | |||
There was a problem hiding this comment.
I moved these into the animated styles so that we don't expose the raw value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-doing the fix from #1691 which regressed in #1676.
This time it's easier to fix at the source. Now that we've moved the shell state into React, I've changed the source of truth to be an Animated value. We can change it directly and make all animations derived from it.
In the future, we should also change this to update with scroll but for now I left it discrete.
Verification
Before
before.mov
After
after.mov
Impact
Low/mid-range Android.
Before
IMG_0816.mov
After
IMG_0819.mov
Test Plan
Verified these elements hide/show as expected: