Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance optimization #1676

Merged
merged 35 commits into from
Oct 14, 2023
Merged

Performance optimization #1676

merged 35 commits into from
Oct 14, 2023

Conversation

ansh
Copy link
Contributor

@ansh ansh commented Oct 12, 2023

This PR does the following:

  • Creates scripts for automated performance testing using Flashlight and Maestro
    • Flashlight only works for Android
    • Maestro allows us to write tests with YAML files instead and avoids the issues that come with using Detox and React Native
  • Fixes warnings in eas.json
  • Removes stray console.logs with a plugin in production code to help JS thread (as recommended by RN dos)
  • Set up Sentry performance monitoring to get performance insights in production applications
  • Moves shell animations to Reanimated and wraps them in a mobx reaction to help avoid re-renders
  • Moves shared shell animations to centralized hook
  • Moves LoadLatestBtn to an animation instead of dynamically changing styles and re-rendering the component
  • Moves FeedPage out of Home and separates concerns of components
  • Re-write some logic of Empty screens and renderItem in Feed and FeedPage so we don't unnecessarily pass components down when not required

@ansh ansh marked this pull request as ready for review October 13, 2023 18:55
docs/testing.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the Reanimated parts lgtm, but haven't tested

@pfrazee
Copy link
Collaborator

pfrazee commented Oct 13, 2023

Load more btn lost it's alignment on desktop web

CleanShot 2023-10-13 at 14 04 02@2x

@pfrazee
Copy link
Collaborator

pfrazee commented Oct 13, 2023

I fixed the load more and FAB behaviors on desktop

Last one, on web tablet the feeds pager tabs are off

CleanShot 2023-10-13 at 14 35 22@2x

@pfrazee
Copy link
Collaborator

pfrazee commented Oct 13, 2023

Those are the only issues I saw, scroll perf seems definitely stronger on web

@pfrazee pfrazee merged commit 8e9cf18 into main Oct 14, 2023
4 checks passed
@pfrazee pfrazee deleted the performance-optimization-1 branch October 14, 2023 01:54
estrattonbailey added a commit that referenced this pull request Oct 19, 2023
…e-post-tags-into-app

* origin/main:
  Fix four gallery images for Firefox (#1710)
  Performance optimization  (#1676)
  Scope drawer drag workaround to feed pagers (#1694)
  Toggle lightbox controls on tap (#1687)
  Fix profile preview jump (#1693)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants