Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tab alignment on the web #1857

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Fix tab alignment on the web #1857

merged 1 commit into from
Nov 9, 2023

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Nov 9, 2023 •
edited
Loading

Fixes an issue @ansh pointed out in another PR.

This line seems to only affect web; I don't see any difference on iOS and Android.

It's pretty odd that none of these styles have changed in a while:

Screenshot 2023-11-09 at 21 52 10

So I don't know how it could have regressed recently, but whatever.

Test Plan

Before:

align_before.mov

After:

align_after.mov

pfrazee
pfrazee approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@pfrazee pfrazee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ez pz

@gaearon gaearon merged commit 664e7a9 into main Nov 9, 2023
4 checks passed
@gaearon gaearon deleted the tabs-web-no-center branch November 9, 2023 21:56
estrattonbailey added a commit that referenced this pull request Nov 9, 2023
@estrattonbailey
Merge remote-tracking branch 'origin' into eric/session-hook
3ef683e 
* origin:
  Fix tab alignment on the web (#1857)
  Show tabs when swiping feeds (#1856)
  Sync top/bottom bar disappearance to the scroll (#1855)
  Hotfix internationalization on mobile (#1854)
  Internationalization & localization (#1822)
  Hide/show header and footer without re-renders, take two (#1849)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfrazee pfrazee pfrazee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaearon @pfrazee