core: ardupilot-manager: Support UDP Server on MavlinkRouter and fix GCS Link default endpoint #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaellehmkuhl
force-pushed
the
allow-udp-server-mavlinkrouter
branch
2 times, most recently
from
2515366 to
deccb26
Compare
rafaellehmkuhl
changed the title
rafaellehmkuhl
force-pushed
the
allow-udp-server-mavlinkrouter
branch
from
deccb26 to
13c8959
Compare
|
Mypy is failing to understand that the connection_type argument is of type EndpointType, and not str. For that i'm ignoring type-check on the lambda line. Related issues: |
rafaellehmkuhl
force-pushed
the
allow-udp-server-mavlinkrouter
branch
from
13c8959 to
7aa698c
Compare
rafaellehmkuhl
changed the title
patrickelectric
requested changes
May 20, 2021
Merged
Now pointing as a UDP Client to `192.168.2.1:14550`, as was original companion, to allow automatically QGroundControl detection.
rafaellehmkuhl
force-pushed
the
allow-udp-server-mavlinkrouter
branch
2 times, most recently
from
53edc10 to
7bff468
Compare
rafaellehmkuhl
force-pushed
the
allow-udp-server-mavlinkrouter
branch
from
7bff468 to
9302576
Compare
patrickelectric
approved these changes
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #240
Fix #254
Fix #255