Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default endpoint for Ground Station communication is not supported by MavlinkRouter #240

Closed
rafaellehmkuhl opened this issue May 18, 2021 · 6 comments · Fixed by #256
Closed
Assignees
Labels
bug Something isn't working must-have Must have feature or change

Comments

@rafaellehmkuhl
Copy link
Member

The "GCS Link" endpoint is of the type "udpin", which is not supported by MavlinkRouter.

Easy solution is to use a type that is supported by all MavProxy, MavlinkRouter and QGroundControl.

@rafaellehmkuhl rafaellehmkuhl added bug Something isn't working must-have Must have feature or change labels May 18, 2021
@rafaellehmkuhl rafaellehmkuhl self-assigned this May 18, 2021
@Williangalvani
Copy link
Member

image

This works well for the rov while we don't have a udpbcast option

@rafaellehmkuhl
Copy link
Member Author

image

This works well for the rov while we don't have a udpbcast option

only problem there is that we need to know the IP of the GCS machine on runtime, right?

@Williangalvani
Copy link
Member

Williangalvani commented May 18, 2021

yes. but while we work on it, I see no issue in using 192.168.2.1. This is the IP where the current companion assumes the GCS is.

at least it will work

@patrickelectric
Copy link
Member

I agree with it, but I believe that is more an QGC issue than ours since it should find the ROV over the network, and not hardcoding stuff and having a GCS as a server.

@rafaellehmkuhl
Copy link
Member Author

Agree with both on that.

What do you think should be our approach today?

Have in mind MavlinkRouter is our default router on core today.

@patrickelectric
Copy link
Member

I would recommend to hardcode the IP as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working must-have Must have feature or change
Projects
None yet
3 participants