Enable block v3 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I pushed a commit to enable switching between v2 and v3. I nuked the code for v2 blinded blocks in the process, and didn't bother with v3 JSON support (for now). |
|
I'll merge this and try rolling it out on the blockprint infra to see how the latest client versions work with v3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #4
added block v3 support. note that block v3 SSZ tests cant be enabled until the following is merged to unstable:
sigp/lighthouse#4902
This PR deprecates the
use_builderfield for v2. For v3 we also assumessz. In future we can delete everything except v3+SSZ.