Clean up blockv3 metadata and client #5015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
enhancement
|
I ended up wanting to test v3 JSON in blockdreamer, so I overhauled the JSON API and made it return the same type as the SSZ one. This PR will now clash with #4813, however unifying the types has simplified things a bit, and could allow us to do nice things in the VC, like select between SSZ (default!) and JSON requests based on a CLI flag. |
michaelsproul
added
ready-for-review
michaelsproul
changed the title
michaelsproul
changed the title
michaelsproul
commented
Dec 20, 2023
realbigsean
approved these changes
Dec 20, 2023
|
Nice!
This was really smart! would be getting pretty hairy otherwise |
pawanjay176
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
execution_payload_valueto the JSON response for blocks/v3. Previously we were not following the spec.ForkVersionedResponseso that it can carry arbitrarymetadata. This is used to smuggle the metadata without adding a new variant ofForkVersionedResponse. This required some refactoring elsewhere, but on the whole I think it's an improvement.produce_blockv3 API. This ensures the headers are checked in the tests, and enables blockdreamer to make use of the header metadata (see: Enable block v3 blockprint-collective/blockdreamer#5).Additional Info
This PR conflicts slightly with #4813. I was thinking we could merge this PR first.
This PR does not include the
builder_comparison_factorchange (ethereum/beacon-APIs#386). That needs to happen in another PR.