Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block-v3 SSZ tests #4902

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Conversation

eserilev
Copy link
Collaborator

@eserilev eserilev commented Nov 3, 2023

Proposed Changes

Add ssz tests for the block v3 endpoint. These tests were missed in the original block v3 PR. Also, these changes are required in this PR blockprint-collective/blockdreamer#5 to test the block v3 ssz flow in blockdreamer

@eserilev eserilev changed the title create block-v3 ssz tests add block-v3 ssz tests Nov 3, 2023
@eserilev eserilev changed the title add block-v3 ssz tests Add block-v3 ssz tests Nov 3, 2023
@eserilev eserilev changed the title Add block-v3 ssz tests Add block-v3 SSZ tests Nov 3, 2023
Copy link
Member

@realbigsean realbigsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

common/eth2/src/lib.rs Show resolved Hide resolved
common/eth2/src/lib.rs Show resolved Hide resolved
@realbigsean
Copy link
Member

bors r+

@realbigsean
Copy link
Member

bors r+

@realbigsean realbigsean added the ready-for-merge This PR is ready to merge. label Nov 7, 2023
@jimmygchen jimmygchen merged commit a380f6e into sigp:unstable Nov 9, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants