feat: MCP client sdk matching pending requests #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* origin/v1.0: stop bubbles filling screen (#495) chore: V1.0 release automation (#493) requires foreign architectures more xcompile deps x compilation tools chore: Cargo build tokenizers (#491) feat: build and release binaries to GH releases (#477) fix: width of bubbles and logging errors (#487) feat: add google provider (#489) feat: flappy goose easter egg (#479)
…ntation * checks out the changes from 'kalvin/mcp-client-trait' branch Co-authored-by: kalvinnchau <[email protected]>
Closed
baxen
reviewed
Dec 20, 2024
kalvinnchau
approved these changes
Dec 20, 2024
Comment on lines
+36
to
+43
| struct TransportServiceInner<T: Transport> { | ||
| transport: Arc<T>, | ||
| router: Mutex<Option<MessageRouter>>, | ||
| initialized: AtomicBool, | ||
| } | ||
|
|
||
| impl<T: Transport> TransportServiceInner<T> { | ||
| async fn ensure_initialized(&self) -> Result<MessageRouter, ServiceError> { |
There was a problem hiding this comment.
Would it be worth exploring the use of the Type State Pattern here? We could get compile time guarantees about the state of the Transport and have no need for the ensure_initialized further down in TransportService::call's method. (Disclaimer: i only recently learned about this pattern https://cliffle.com/blog/rust-typestate/)
There was a problem hiding this comment.
It would probably be possible to also use the Type State Pattern on the McpClient itself for more compile time guarantees
There was a problem hiding this comment.
this makes a lot of sense. i will defer this to another PR for now
lifeizhou-ap
added a commit
that referenced
this pull request
Dec 20, 2024
* v1.0: feat: MCP client sdk (#505)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a minimal MCP client sdk which will be used to write goose as an MCP client.
https://spec.modelcontextprotocol.io/specification/basic/
Methods we implemented: