feat: add google provider #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* v1.0: chore: don't require UV to download tokenizers (#473)
zakiali
reviewed
Dec 17, 2024
| @@ -2,6 +2,7 @@ use super::{ | |||
| anthropic::AnthropicProvider, base::Provider, configs::ProviderConfig, | |||
| databricks::DatabricksProvider, ollama::OllamaProvider, openai::OpenAiProvider, | |||
| }; | |||
| use crate::providers::google::GoogleProvider; | |||
There was a problem hiding this comment.
move this up into the super for consistency?
lifeizhou-ap
commented
Dec 17, 2024
download_tokenizer_files.py
Outdated
| @@ -16,6 +16,7 @@ | |||
| "Xenova/gpt-4o", | |||
| "Xenova/claude-tokenizer", | |||
| "Qwen/Qwen2.5-Coder-32B-Instruct", | |||
| "Xenova/gemini-nano", | |||
There was a problem hiding this comment.
Hi @zakiali would you please review this to check whether this file is correct? Thank you
There was a problem hiding this comment.
Doing a bit googling, it looks like gemini 1.5 flash uses the same tokenizer as gemma 2, so we can probably use this instead https://huggingface.co/Xenova/gemma-2-tokenizer
michaelneale
added a commit
that referenced
this pull request
Dec 18, 2024
salman1993
added a commit
that referenced
this pull request
Dec 18, 2024
* origin/v1.0: stop bubbles filling screen (#495) chore: V1.0 release automation (#493) requires foreign architectures more xcompile deps x compilation tools chore: Cargo build tokenizers (#491) feat: build and release binaries to GH releases (#477) fix: width of bubbles and logging errors (#487) feat: add google provider (#489) feat: flappy goose easter egg (#479)
jsibbison-square
added a commit
that referenced
this pull request
Dec 19, 2024
* v1.0: stop bubbles filling screen (#495) chore: V1.0 release automation (#493) requires foreign architectures more xcompile deps x compilation tools chore: Cargo build tokenizers (#491) feat: build and release binaries to GH releases (#477) fix: width of bubbles and logging errors (#487) feat: add google provider (#489) feat: flappy goose easter egg (#479)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added google provider