fix: width of bubbles and logging errors #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
alexhancock
approved these changes
Dec 17, 2024
| @@ -8,8 +8,8 @@ export default function UserMessage({ message }) { | |||
| const urls = extractUrls(message.content, []); | |||
|
|
|||
| return ( | |||
| <div className="flex justify-end mb-[16px]"> | |||
| <div className="flex-col max-w-[90%]"> | |||
| <div className="flex justify-end mb-[16px] w-full"> | |||
There was a problem hiding this comment.
Does this change make every user message the full width of the chat space?
There was a problem hiding this comment.
Solution would be max-w-full if so and we don't want that. This would let a single word message like "hi" have a small bubble, but constrain maximum width.
There was a problem hiding this comment.
no doesn't make it full width
salman1993
added a commit
that referenced
this pull request
Dec 18, 2024
* origin/v1.0: stop bubbles filling screen (#495) chore: V1.0 release automation (#493) requires foreign architectures more xcompile deps x compilation tools chore: Cargo build tokenizers (#491) feat: build and release binaries to GH releases (#477) fix: width of bubbles and logging errors (#487) feat: add google provider (#489) feat: flappy goose easter egg (#479)
jsibbison-square
added a commit
that referenced
this pull request
Dec 19, 2024
* v1.0: stop bubbles filling screen (#495) chore: V1.0 release automation (#493) requires foreign architectures more xcompile deps x compilation tools chore: Cargo build tokenizers (#491) feat: build and release binaries to GH releases (#477) fix: width of bubbles and logging errors (#487) feat: add google provider (#489) feat: flappy goose easter egg (#479)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps us diagnose by ensuring all error messages are logged to main.log even if they are in browser process, and also fixes the bubble width overflow problem and invisible user messages