Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added system type to file management and upload to CF #211

Merged
merged 3 commits into from
Mar 17, 2021
Merged

Conversation

krichardsson
Copy link
Contributor

@jonasdn jonasdn marked this pull request as ready for review March 17, 2021 10:09
Copy link
Contributor

@jonasdn jonasdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a nit about using the const variable instead of magicish number

cflib/localization/lighthouse_config_manager.py Outdated Show resolved Hide resolved
@krichardsson krichardsson added this to the next-release milestone Mar 17, 2021
@ataffanel ataffanel merged commit e86be69 into master Mar 17, 2021
@ataffanel ataffanel deleted the dev-lh-file branch March 17, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants