Lighthouse: Allow to set system type at runtime #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
System type (Lighthouse V1 or V2) can be set with a parameter. The new setting is stored in persistent storage and loaded on next statups. When changing types, the current configuration (geometry and calibration) is cleared from RAM. By default lighthouse V2 is used if no setting exists in storage.
jonasdn
approved these changes
Mar 11, 2021
| * @brief Fetch system type from storage and set it in ligthouseCore | ||
| * | ||
| */ | ||
| void lighthouseStorageInitializeSystemTypeFromStorage(); |
There was a problem hiding this comment.
nit: missing newline at end of file
| if (fetched == typeSize) { | ||
| lighthouseCoreSetSystemType(type); | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: missing newline at eof
jonasdn
reviewed
Mar 11, 2021
| default: | ||
| // Do nothing if the type is not in range, stay on the previous processor | ||
| return; | ||
| break; |
There was a problem hiding this comment.
nit: maybe remove the break;? It might trigger unreachable code on some linters?
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System type (Lighthouse V1 or V2) can be set with a parameter. The new
setting is stored in persistent storage and loaded on next statups.
When changing types, the current configuration (geometry and
calibration) is cleared from RAM.
By default lighthouse V2 is used if no setting exists in storage.