-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly define trade limits #264
Comments
I dont understand why sellers have limits. Anyone remember a reason for that? If not we have to remove that. |
Don't remember myself why BTC sellers have also the staged limits. |
This is in accordance with bisq-network/proposals#264 Any account type that doesn't need signing can now trade the full amount immediately, same goes for signed type accounts that are selling. Signed type accounts that are buying now has minimum limit (0.01 BTC) up until 30 days after getting signed, when they get the full limits.
Reducing account age protection to 1 months is a too risky change IMO.
I dont understand that. Can you explain it in more details? |
Kinda 50/50 here, but I'd love to see higher limits for users that have been signed long enough. Swapping 1-2 BTC for fiat per trade would be great. |
@chimp1984 The proposal is to remove any restrictions for account types that are not risky, so only those that get signed would have restrictions. There also would be no restrictions for signed types accounts that are selling. Current limits for buying with a signed type account is:
@gordonel it is possible to trade larger amounts for safer fiat transfer methods, the most common ones like SEPA and Zelle are considered risky though so they max out at 0.25 BTC. |
Would aging still apply to small fiat markets, where signing isn't required? Except face to face and and other cash based methods, is quite hard to know if there's no chargeback risk at all. For those and alts, aging doesn't make much sense. Also, I think that if just after signing buy limits would double to 0.02 btc it would increase likeability to go through signing process and make effects of signing more evident to newcomers. |
Overall this sounds great. Should help reduce market fragmentation, increase trade sizes, and encourage sellers to sell.
Also wondering about this. Assuming account signing will eventually be implemented for buying with high-risk payment methods in any new market, does it make sense to impose aging limits during the bootstrap phase or not? I'm not sure. |
After reading the excellent docs at https://bisq.wiki/Account_limits I would suggest following changes: Remove seller restrictions for both account signing and account age. Sellers have no limit restrictions beside the limit defined by the payment method. For SEPA or Zelle they could sell 0.25 BTC just from the start. Remove account age rules, as they are overrules anyway from the account age signing for buyers. Keep the existing rule there but make it easier to communicate as its just the time after getting signed which counts. When the account has been created has no relevance. Time after getting signed Maximum Trade Size (Buy) Maximum Trade Size (Sell) I did not find any reason why we should apply the restrictions to sellers, if anyone remember any reason please chime in! To further reduce the hurdle with the limits we should find alternative ways to earn trust. There have been some ideas floating around but none matured yet to become concrete... |
Hi as a new user of Bisq I am all for clearly defining trade limits. So reading from the wiki it says:
The Payment methods page has some information about account signing but not enough to note here. @m52go has made a super good video All About Account Limits on Bisq (Fiat Only) it covers the technical aspects well but does not really answer my question on the reasons for account limits. I expect account limits have grown with Bisq over time through lots of discussion between contributors but have not been documented in a way that makes it clear and obvious to new users; what are the reasons for account limits? If anyone has a link about where I can find more information about the reasons for account limits please share a link below. I think the reasons for account limits could be more clearly defined. Once they are better defined it will be much easier to have a conversation and reach consensus about how they should be set. For new users such as myself it would be nice to know why these were created. Often reasons can be forgotten over time for example in the discussion above about why sellers have limits. Current account limit reasoning definition
My questions based on the current account limit reasoning definition Should account limits apply only to fiat payment methods with chargeback risk? Is Bisq goal to allow for trading immediately? Is Bisq goal is allow honest users to trade? Is Bisq goal to allow for trading with utmost privacy? Do altcoins accounts have full trading capability right away, I think the limit is 2 BTC? Why is this? My questions based on not fully understanding reasons for Bisq's account limits Are account limits used to limit losses to users? I also think the reasons for having account aging and account signing could be better defined. I get the impression from reading between the lines that the account signing / aging protocols are a cause of friction for users and contributors. More problems, more support issues etc. Maybe this is me getting the wrong end of the stick? Apologies for the wall of questions. They are rhetorical in nature, and a way for me to try and be a logical as in documenting my thought process if only to help myself! Please don't feel I want an answer to all. Main question is the last one: Is there a shared consensus among all stakeholders for the above answers? is one needed?As a user of Bisq I think there I am confident that Bisq can achieve what it desires. But it first has to be clear about what that is :) |
I try to summarize the important motivations: Account limits are in place as protection against chargeback scams and as loss limitation for mediators and arbitrators in case they make a mistake and pay out to the wrong trader (that happened and they had to pay from their pocket for their mistake, which can be very expensive with a 2 BTC trade). So payment methods with no chargeback risk (like altcoins) do have the max limit of 2 BTC and that limit is only in place to limit mediators/arbitrators risk exposure. Bisq's first priority is security. If its not secure to trade on Bisq is has failed. Of course there is no 100% security but that is the priority number 1. I think the answers to above questions can be derived from those priorities. I guess there might be different shades as all those main priorities overlap and have their trade-offs. With being too extreme on security we will lose users and liquidity, so we have to find the right balance. The discussion in that proposal is an attempt to re-balance. Account age signing was added after we had a serious SEPA chargeback scam. The account age limits turned out to be not enough protection so we needed to improve security. This is also the reason why we have to be very careful when "tuning" this feature. It was basically the only feasible idea how to protect Bisq against scammers in a way compatible with Bisq's vision. If we weaken that protection by increasing the limits too much and chargeback scammers come back it would have a terrible reputation damage and we have to question if Bisq's security model is sufficient. If we fail on security Bisq has failed.
I shared my point of view. I assume many core contributors share more or less a similar view, but best they respond themselfes ;-). |
Thanks for explaining your point of view. I thought that was the reason for account limits. In the definitions of the accounts limits I referenced it does not make this clear. Perhaps if this consensus is shared it could be added.
Thanks. I agree with Security and Privacy being 1 and 2.
So liquidity is important too :) Perhaps this can also be added to a definition of reasons for account limits. I agree there is a trade-off to be made.
I really like the account signing / aging feature. I would sacrifice immediacy for more security. My observations are that all the current popular fiat payment methods based on data from Keybase's bisq#growth-alerts channel are:
*would be interesting to see data from a full year. Not sure is this has been published anywhere? I think the account signing feature provides a positive appearance to Bisq traders. When I have used Bisq to purchase BTC the following is true:
As a UK based user this means I mostly avoid the GBP market (faster payments) and buy on the EUR market (SEPA). I would be a proponent on making all fiat accounts have a signing mechanism. I think this would increase buyer confidence.
Thanks can you point me to where these are well documented? I had trouble finding clearly defined vision and values. How you get where your going, what methods you use to get there will change a lot, but should your vision and what you believe in should be clearly defined from the outset? |
See "Most common payment methods" in this post.
Really? The general sentiment is that signing is a necessary evil. Is lack of signing the reason you avoid Faster Payments?
Perhaps this wiki article helps? |
Thanks, that link is not working for me? Also has Trojan pop-up?
Yes, when buying BTC seeing the seller is using a signed account gives me more confidence. I like seeing the little tick on the badge! This along with with the seeing a good account age of increases my confidence about the person I am buying off. Yes, the increased confidence I have when trading with signed accounts means I prefer to use SEPA and Revolut payment methods. I avoid Faster Payment. Might adding signing to Faster Payments increase trading volume? What do you see as 'evil' when it comes to account signing?
There is no mention of vision or values in the introduction. It does nicely define the mission though, but a mission is not a vision :) |
@pazza83 Signing between traders happens after a successful trade with a seller that can sign and the buyer that isn't yet signed. For a market to have signing some accounts need to be signed by either an arbitrator or by some other means. This takes time and is likely disruptive to the market. The data stored to track the signed accounts affects privacy negatively. It's not terrible, but clearly better if it can be avoided from a privacy perspective. You mention that the signed check mark feature inspires trust. I'm not really sure that's a good thing, we live in a world of "Don't trust, verify." Having said that, aged accounts could get some similar UI feature to show they are old enough. Suggested limitsFrom the discussion I see no objections to removing all time limits for sellers, be they account age or account signing type. Buying will then have the following limits Account aging0-30 days old: 0.25 * MAX_LIMIT = 0.0625 BTC Account signingunsigned: 0.01 BTC Changing the minimumThe reason 0.01 BTC was chosen was to make it unprofitable to cash out stolen bank accounts. If we raise this too soon it might make it profitable again. I think keeping this value low enough to deter scammers only makes sense. The other option is to remove it and accept that there will be scams. I think that would be rather bad for Bisq's reputation. |
@sqrrm thanks for explaining the reasons why signing can be disruptive and cause problems with privacy. All makes more sense now. Is signing not a form of "Don't trust, verify."? Trades using a signed account have at least been verified by one other user as having matching account details. It also demonstrates that they have at least completed one successful trade. In a perfect world signing would proves that the user's given account details are correct. Trades from users using accounts that do not require signing cannot be verified in any way prior to trading.
This would be good 👍 For new users Bisq can be a scary place to trade. Some changes to the UI would make it less so. Even a simple thing like showing account age in the offer column for payment methods that do not require signing would help. This is done for payment methods that require signing. |
I think we should remove the limits for methods where no signing is used (and only account age is used). We have seen with the SEPA chargebacks that the account age is not sufficient anyway, so why should we keep it as protection when it has failed already and only cause friction for new users. Showing account age thus is for sure still a good weak tool for "reputation". |
This is in accordance with bisq-network/proposals#264 Any account type that doesn't need signing can now trade the full amount immediately, same goes for signed type accounts that are selling. Signed type accounts that are buying now has minimum limit (0.01 BTC) up until 30 days after getting signed, then the limit is increased to 0.5 times the max limit (0.125 BTC) and after 60 days they get the full limits (0.25 BTC).
PR at bisq-network/bisq#4744 which removes limits for all types of trades except buying with signed account types. Limits as suggested unsigned: 0.01 BTC |
Implemented and merged |
I am sorry I saw this proposal too late. Maybe I undertood it incorrectly, but I was not aware that BTC sellers ever had trading limits in fiat transactions. As far as I remember there was a very serious problem for sellers getting their account signed by performing a successful sell transaction (they could get a stolen account signed, and the real owner would not notice or complain about receiving unexpected money). But as long they don't get signed, I don't see the problem of being able to sell the max amount from day 0 as there is no chargeback risk with them. |
We do not sign the seller only the buyer as far I know (@sqrrm can you confirm?). |
Right, only buyers get signed. The first month after the signed witness release I think both parties got signed but later we changed it to only the buyer getting signed. |
The current state of affairs when it comes to trade limits isn't perfect, an example is bisq-network/bisq#4482
I have looked through the code and I'm still not 100% sure what limits we have in all cases, but I've started refactoring the code to make it understandable. I would then like to set limits that are reasonable, easy to follow in the code and also update documentation.
My current understanding of fiat limits
For non risky methods, time after account creation and signed accounts that are selling, time after signing
0-30 days: 0.25 * MAX_LIMIT = 0.0625 BTC
30-60 days: 0.5 * MAX_LIMIT = 0.125 BTC
>60 days: MAX_LIMIT = 0.25 BTC
For signed accounts that are buying, time after signing
<0 days: 0.01 BTC
0-30 days: 0.01 BTC
30-60 days: 0.5 * MAX_LIMIT = 0.125 BTC
>60 days: MAX_LIMIT = 0.25 BTC
Proposal
I suggest that we change it to
First case
MAX_LIMIT no matter the age. That means 0.25 BTC trade limit for all non risky methods immediately and selling for risky methods.
Second case
<0 days: 0.01 BTC
0-30 days: 0.01 BTC
>30 days: MAX_LIMIT = 0.25 BTC
The text was updated successfully, but these errors were encountered: