Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account age popup shows wrong durations #4482

Closed
chimp1984 opened this issue Sep 5, 2020 · 3 comments
Closed

Account age popup shows wrong durations #4482

chimp1984 opened this issue Sep 5, 2020 · 3 comments

Comments

@chimp1984
Copy link
Contributor

Account age signing requires only 1 month but the popup at account creation shows 2 months. Maybe there are more relicts from the time when 2 months was considered.
Screen Shot 2020-09-04 at 20 37 04

@ghost
Copy link

ghost commented Oct 14, 2020

This seems to match what is described in the wiki. https://bisq.wiki/Account_limits

The code matches the description too.

I don't see a problem.

@chimp1984
Copy link
Contributor Author

@sqrrm Can you chime in? I thought the code has been changed so that after 1 months there is the full trade amount?

@sqrrm
Copy link
Member

sqrrm commented Oct 15, 2020

It's quite confusing actually. I think I'll take another look at this and clean up the signing code.

Currently the limit is 0.01 BTC for the first month, 0.125 BTC (0.5 max amount for risky account type) for the second month and then 0.25 BTC (max amount). Users can sign others 1 month after signing. Sellers have some rules that I think are not actually used. There were too many changes in the months after signing release that it's not very clear.

I think it's best to make it:

  • sellers can sell full amount at all times
  • buyers limit first 30 days after signing is 0.01 BTC
  • buyers get full limit and can sign other after 30 days

Very easy to explain, can remove many cases in code and should be mostly backwards compatible. (I think there will be a conflict for some old users taking offers from accounts signed 30-60 days back that make larger offers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants