Cleanup signed witness #4744
Merged
Cleanup signed witness #4744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in accordance with bisq-network/proposals#264 Any account type that doesn't need signing can now trade the full amount immediately, same goes for signed type accounts that are selling. Signed type accounts that are buying now has minimum limit (0.01 BTC) up until 30 days after getting signed, then the limit is increased to 0.5 times the max limit (0.125 BTC) and after 60 days they get the full limits (0.25 BTC).
ripcurlx
reviewed
Nov 5, 2020
| } | ||
| long limit = OfferRestrictions.TOLERATED_SMALL_TRADE_AMOUNT.value; | ||
| if (direction == OfferPayload.Direction.BUY && isRisky) { | ||
| // Used only for bying of BTC with risky payment methods |
There was a problem hiding this comment.
Nit: Just a little typo in the old code buying vs bying
ripcurlx
approved these changes
Nov 5, 2020
There was a problem hiding this comment.
utACK
Code changes are looking fine and reflect the consensus found in bisq-network/proposals#264.
@m52go This will need a couple of changes (will make it easier for users) in https://bisq.wiki/Account_limits when v1.5.0 gets released.
|
We definitely have to keep an eye on all popups during trade and account creation to see if the new limits are communicated correctly everywhere. I guess a couple of changes will be required here and there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements bisq-network/proposals#264
Payment methods using only accountagewitness can trade the full amount immediately, both when buying and when selling.
Payments methods with signing can trade the full amount immediately when selling, but has limits for buying according to the schedule described: