Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For January - April 2018 #61

Closed
blabno opened this issue Apr 30, 2018 · 8 comments
Closed

For January - April 2018 #61

blabno opened this issue Apr 30, 2018 · 8 comments
Assignees

Comments

@blabno
Copy link

blabno commented Apr 30, 2018

Basic information

Specify the amount of BSQ you are requesting, and the BSQ address that amount should be paid to:

  • BSQ amount requested: 3950
  • BSQ address: B1ARsZ9kk1wANuuw9EDFnWF9ERwa1x5N2Rm

Details

Provide links to the work you are requesting compensation for, along with any comments or explanations that will help stakeholders understand its value.

This request covers all my closed PRs since the beginning of my adventure with Bisq (january 2018), excluding work on API and mobile which is not finished yet.

@cbeams
Copy link
Contributor

cbeams commented Apr 30, 2018

Thanks @blabno, great to see your first compensation request after all this time!

Not sure whether you've caught up with bisq-network/proposals#19 yet, but most of the PRs above have not yet actually been delivered per the definition of that term in the proposal.

We can see, for example, that bisq-network/bisq#1302 was delivered in v0.6.5:

$ git log --grep 'Merge pull request #1302' --pretty=format:%H | xargs git tag --contains
v0.6.5
v0.6.6
v0.6.7

But other bisq-desktop PRs listed above have not shipped in any release yet, and thus have not been delivered, e.g.:

$ git log --grep 'Merge pull request #1311' --pretty=format:%H | xargs git tag --contains
[no tags listed]

So, in keeping with the proposal, could you create a second compensation request, titled [WIP] For May 2018 and move bisq-desktop PR entries 1311–1416 to it? These will all be delivered with the forthcoming v0.7.0, which will surely ship by the time we do our May voting.

With regard to the bisq-core / bisq.asset PRs, these are an interesting case, because while the software itself has not been delivered in a release, the value of these changes has indeed been delivered in the sense that the target users (people who want to list an asset) have been able to use this new infrastructure and documentation, and indeed they have in fact been using it. So I'd say keep these PRs in for this month if you like. A bit of an unusual scenario, this one, but an interesting exploration of what it means to deliver value to users in any case. You can also feel free to move these to the May PR, too. Just wanted to walk through the thinking a bit.

@cbeams cbeams changed the title For January - April 2018 [WIP] For January - April 2018 May 5, 2018
@cbeams
Copy link
Contributor

cbeams commented May 5, 2018

Per a conversation with @blabno yesterday, I've prefixed the title of this request with [WIP] and will not add it to this month's voting spreadsheet in #58. @blabno would prefer to defer the entire request until next month when most or all of the items above will be delivered (with bisq-desktop v0.7.0) and will therefore be eligible for compensation.

@ManfredKarrer
Copy link

@blabno Is that request compete now as it is still marked WIP? This months will be the last requests on the spreadsheet...

@blabno blabno changed the title [WIP] For January - April 2018 For January - April 2018 Apr 2, 2019
@blabno blabno changed the title For January - April 2018 [WIP] For January - April 2018 Apr 2, 2019
@blabno
Copy link
Author

blabno commented Apr 2, 2019

Tasks are complete but I need to get new BSQ address.

@ManfredKarrer
Copy link

@blabno Please change the title / remove WIP. Today EOD voting starts....
@ripcurlx This request should be added as well....

@blabno blabno changed the title [WIP] For January - April 2018 For January - April 2018 Apr 2, 2019
@blabno
Copy link
Author

blabno commented Apr 2, 2019

Ok, so I've updated my BSQ address. This issue is ready.

@ripcurlx
Copy link
Contributor

ripcurlx commented Apr 3, 2019

@blabno sorry for closing the issue by mistake

@ripcurlx
Copy link
Contributor

ripcurlx commented Apr 6, 2019

Closing as complete, see #243 (comment).

@ripcurlx ripcurlx closed this as completed Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants