Make arbitration chat messages selectable #1326
Conversation
| textArea.setPrefSize(800, 600); | ||
|
|
||
| Scene scene = new Scene(textArea); | ||
| Stage stage = new Stage(); |
There was a problem hiding this comment.
Most of this code comes from ContractWindow.java.
That class also sets owner (I'm not sure what that is for).
https://github.com/bisq-network/exchange/blob/master/gui/src/main/java/io/bisq/gui/main/overlays/windows/ContractWindow.java#L205
There was a problem hiding this comment.
ACK.
I've tested these changes and they work well. @keo-bisq, heads-up: you can now double-click on arbitration chat messages and a window like the one below will pop up, where you can select and copy any portion of the text.
@bisq-network/docs-maintainers, this is also good for users to know, and is something we should add to our (currently non-existent) documentation.
Thanks, @blabno!
…at-messages-selectable Make arbitration chat messages selectable
Actually, we shouldn't rely on documentation to reveal these sort of "hidden features". We should add an affordance to the UI that makes it obvious to the user that this feature is there. We could (1) add a second icon next to the "copy to clipboard" icon that's already there, or (2) just change the behavior of the existing button to open this dialog instead. I'm open to either. Thoughts, @ripcurlx, @ManfredKarrer, @keo-bisq? @blabno, feel free to open a follow-on issue about this. |
|
I would prefer to make the text in the chat selectable. That would not require any user instruction. I will not have time to look into it but it was not trivial as far I remember from the text component which is used. But with a bit of effort I am sure it can be made. |
|
I had another look.... The hacks i found are using an invisible Label for layout and put a Textarea with the correct size over it (taken from the label) and use styles to look like a label (transparent background). Would be good to make a component which integrates that hack or even better merge the functionalities of Label and Textarea, thought that might be a bit more tricky I assume. |
|
@ripcurlx Maybe you have an idea? |
|
Maybe we could do something like this https://stackoverflow.com/questions/44173811/how-to-make-a-javafx-label-selectable on single mouse click. Besides that I also didn't find a perfect solution that is ready to use. |
|
Did not like that so much to add a new behavior. It should just behave like expected to select a text. |
|
@ManfredKarrer, do you want to revert this change after all? |
|
I dont mind. It might be an improvement to current copy icon and as its for arbitrators only i dont see a big usability issue. A proper selectable label component seems to be not trivial and for now maybe not worth the effort. |
blabno
deleted the
feature/1058-make-arbitration-chat-messages-selectable
branch
Fixes #1058