-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support quick access to top nav items with Alt 1–9 keyboard shortcuts #1302
Support quick access to top nav items with Alt 1–9 keyboard shortcuts #1302
Conversation
Supports left Alt on linux. I need to obtain Mac to test that rounted sharp key. |
I just quickly tested on mac, none of the keys work. |
Also, @blabno, it's probably best to implement this in a way that follows the existing approach for supporting keyboard shortcuts, which you can find at https://github.com/bisq-network/exchange/blob/master/gui/src/main/java/io/bisq/gui/app/BisqApp.java#L249-L284. If you follow that convention, these keyboard shortcuts should "just work" across all platforms, or at the very least, they will work as well as other, existing, keyboard shortcuts do across all platforms. For example, line https://github.com/bisq-network/exchange/blob/master/gui/src/main/java/io/bisq/gui/app/BisqApp.java#L261, is where the |
fd7130c
to
e367df0
Compare
@cbeams I've pushed new commit using suggested approach. You can give it a try. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NACK. The substance of the PR looks good, and I've tested it locally on my Mac, where everything works as expected. Just need to clean up the imports and we're good.
import io.bisq.gui.common.view.FxmlView; | ||
import io.bisq.gui.common.view.InitializableView; | ||
import io.bisq.gui.common.view.View; | ||
import io.bisq.gui.common.view.ViewLoader; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't expand these imports or the others that have been expanded below. The built-in IDEA settings should handle this correctly when running Optimize Imports
. You may not be sync'd up correctly with those settings, or perhaps you're using some other IDE, in which case you'll need to take greater care to get it right manually.
In any case, please keep PRs atomic and avoid mixing in unrelated changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't see .gitignore
ignores .idea
but actually keeps code style.
I've optimized imports using Bisq code style.
e367df0
to
6453eaa
Compare
ACK, thanks @blabno! Note that the next compensation request voting period starts tomorrow, and you have until end of day today to submit a request for this work if you'd like to. Otherwise you can always submit for a subsequent voting period, no problem. Instructions are at https://github.com/bisq-network/docs/blob/master/dao/phase-zero.adoc#submit-a-compensation-request. With regard to how much you should ask for, please gauge that based on how much value you believe this change adds to Bisq, the Bisq network, and its users. Not "how much time you spent on it". You can look at other compensation requests to get a gauge of things, and of course, feel free to ask around in Slack or elsewhere to see if the amount you're requesting seems reasonable to others. |
…s-to-top-nav-items Support quick access to top nav items with Alt 1–9 keyboard shortcuts
Fixes #1286