Skip to content
This repository has been archived by the owner on Jun 17, 2020. It is now read-only.

Extract bisq.asset package to its own repository #99

Closed
6 tasks done
blabno opened this issue Apr 23, 2018 · 4 comments
Closed
6 tasks done

Extract bisq.asset package to its own repository #99

blabno opened this issue Apr 23, 2018 · 4 comments
Assignees

Comments

@blabno
Copy link

blabno commented Apr 23, 2018

  • Do the extraction into blabno/bisq-assets (a repository of your own creation)
  • Submit a PR to bisq-network/bisq-docs updating list-asset.adoc accordingly
  • Submit a PR to bisq-network/bisq updating the .mrconfig and .gitignore files accordingly.
  • Submit a PR to bisq-network/bisq-core deleting the package there and requesting @cbeams to review blabno/bisq-assets and transfer it into the bisq-network repo
  • (at the same time as the PR above) Grant @cbeams admin rights on blabno/bisq-assets so he can actually perform the repo transfer
  • @cbeams does the transfer and merge all the above PRs
@cbeams
Copy link
Contributor

cbeams commented Apr 23, 2018

Thanks, @blabno. Note (for others) that we decided to do this based on the conversation at https://bisq.slack.com/archives/C1267HFD1/p1524468933000097.

@cbeams
Copy link
Contributor

cbeams commented Apr 24, 2018

Thanks, @blabno. Looking into all this now.

@cbeams
Copy link
Contributor

cbeams commented Apr 27, 2018

Closing as complete. Thanks @blabno for putting all of this together. From this point out, I'll wait for your review on incoming PRs to the new bisq-asset repository, and then I'll merge. After we work that way for a while, say one month and I generally don't have any follow-up comments on your reviews, then I'll grant you maintainer rights on the repo so you can just take care of everything yourself. I'll set up a role and a @bisq-network/assets-maintainers team as well.

@cbeams cbeams closed this as completed Apr 27, 2018
cbeams added a commit to bisq-network/bisq-multirepo that referenced this issue Apr 27, 2018
This change should have been included in #4, but I forgot to mention it
to @blabno when planning this work.

See bisq-network/bisq-core#99
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants