This repository has been archived by the owner on Sep 6, 2018. It is now read-only.
Extract bisq.asset package to its own repository. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
cbeams
approved these changes
Apr 24, 2018
There was a problem hiding this comment.
ACK, thanks @blabno. A couple nits:
- Please don't end commit subject lines with a period.
- Please use shorter branch names.
extract-assetswould have been sufficient for example. The reason for this is that long branch names blow up the length of merge commit subject lines.
cbeams
added a commit
that referenced
this pull request
Apr 24, 2018
…to-its-own-repository Extract bisq.asset package to its own repository.
cbeams
added a commit
that referenced
this pull request
Apr 27, 2018
This change should have been included in #4, but I forgot to mention it to @blabno when planning this work. See bisq-network/bisq-core#99
ManfredKarrer
pushed a commit
to ManfredKarrer/archived_bisq
that referenced
this pull request
Jun 26, 2018
This link does not yet work, but will when bisq-network#4 is complete.
ManfredKarrer
pushed a commit
to ManfredKarrer/archived_bisq
that referenced
this pull request
Jun 26, 2018
ManfredKarrer
pushed a commit
to ManfredKarrer/archived_bisq
that referenced
this pull request
Jun 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.