Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 62 #1613

Open
alvasw opened this issue Sep 5, 2024 · 1 comment
Open

For Cycle 62 #1613

alvasw opened this issue Sep 5, 2024 · 1 comment
Milestone

Comments

@alvasw
Copy link

alvasw commented Sep 5, 2024

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 7500.00
  • USD requested: 15000
  • BSQ rate: 2.00 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 61 #1586

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
bisq2: Only bind servers to all interfaces on Whonix dev bisq-network/bisq2#2628

The Bisq P2P ports are exposed to the local network even when Tor is the only selected network. This is only needed on Whonix.

bisq2: packaging: Add Windows MSI support dev bisq-network/bisq2#2629

Users have to manually update Bisq and to support auto-updates we need to ship msi files. We can't use the existing exe file because it requires user interaction during installation or updating.

bisq2: bitcoind: Download and verify SHA256SUMS file dev bisq-network/bisq2#2630
bisq2: Gradle: Support SHA256 hash verification dev bisq-network/bisq2#2739
bisq2: Verify and unpack bitcoind to resources dev bisq-network/bisq2#2740
bisq2: wallets: Don't wait for subprocess shutdown after response dev bisq-network/bisq2#2741

We send a stop RPC call and wait for the subprocess after receiving a success/ok message. This is unnecessary because we received a success reply already.

bisq2: wallets: Fix bitcoind deadlock dev bisq-network/bisq2#2742

We parse stdout and wait for the "init message: Done loading" line to
detect when bitcoind is ready. After seeing this line, we stop reading
stdout causing the stdout buffer to fill up. When the stdout buffer
fills up, bitcoind waits until its parent process reads from it but this
unfortunately never happens leading to a deadlock.

bisq2: BitcoindProcess: Reuse BitcoinDaemon class instance in stop call dev bisq-network/bisq2#2743
bisq2: Remove BitcoindZeroMqRawTxIntegrationTests dev bisq-network/bisq2#2744

The assumptions and expectations of the tests are wrong.

bisq2: bitcoind: Fix blockHash ZMQ test dev bisq-network/bisq2#2745

The test mines blocks and waits until it sees the block hashes of the
mined blocks over ZMQ. Unfortunately, ZMQ publishers are stateless and
can't re-transmit lost messages [1]. Consequently, the test was wrong.
The fixed test subscribes to the publisher, starts mining blocks, and
waits until it observes a new block hash.

bisq2: Remove BitcoindMineInitialRegtestBlocksIntegrationTest dev bisq-network/bisq2#2746

The assumptions and expectations of the tests are wrong.

bisq2: bitcoind: Remove the 'wait until blocks mined' functionality dev bisq-network/bisq2#2747

The implementation is wrong.

bisq2: Remove BitcoindSendUnconfirmedTxIntegrationTests dev bisq-network/bisq2#2748

The test is wrong.

bisq2: BitcoindRegtestSetup: Remove unnecessary 'throws InterruptedException' dev bisq-network/bisq2#2749
bisq2: BitcoindRegtestSetup: Remove unnecessary 'throws InterruptedException' dev bisq-network/bisq2#2755
bisq2: Support bitcoind 24.0.1 dev bisq-network/bisq2#2756

Both fields were added in Bitcoin Core 24.0.1.

bisq2: Support bitcoind 25.0 dev bisq-network/bisq2#2757
bisq2: Support bitcoind 26.0 dev bisq-network/bisq2#2758
bisq2: regtest: Apply bitcoin binary Gradle plugin dev bisq-network/bisq2#2759
bisq2: bitcoind: Use project bitcoind in tests dev bisq-network/bisq2#2760

The tests use the installed bitcoind binary. To make the test failures
reproducible it's better to run the tests with the officially supported
Bitcoin Core version.

bisq2: Move JUnit 5 BitcoindExtension to wallets.regtest module dev bisq-network/bisq2#2762

The wallets.regtest can't depend on any Bisq 2 API to be able to re-use
the bitcoind regtest module in Bisq 1. I migrated our BitcoinJ fork to
the upstream version but Bisq 1 uses deprecated/removed BitcoinJ APIs,
and it's too risky to update critical code without testing the changes.
Bisq 1 doesn't have any bitcoind-based integration testing code and
quicker to re-use Bisq 2 bitcoind integration test infrastructure.

bisq2: Move DaemonProcess to wallets.regtest module dev bisq-network/bisq2#2763
bisq2: Move CannotStartProcessException to wallets.regtest module dev bisq-network/bisq2#2764
bisq2: Move ProcessConfig to wallets.regtest module dev bisq-network/bisq2#2765
bisq2: regtest: Remove dependency to process module dev bisq-network/bisq2#2766
bisq2: Create composed module for core, bitcoind, json-rpc, regtest dev bisq-network/bisq2#2767
dev 15000 Total for items above.
@alvasw
Copy link
Author

alvasw commented Sep 5, 2024

29f3b75e9050ded89c6801b2e9e9b037e4a390bc42a01d371f2ee2b60588c4b4

@MwithM MwithM moved this to In Review in Compensation Request Board Sep 7, 2024
@MwithM MwithM added this to the Cycle 62 milestone Sep 7, 2024
@MwithM MwithM moved this from In Review to Proposal Submitted in Compensation Request Board Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Proposal Submitted
Development

No branches or pull requests

2 participants