-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bitcoind: Use project bitcoind in tests #2760
Merged
HenrikJannsen
merged 11 commits into
bisq-network:main
from
alvasw:use_project_bitcoind_in_tests
Sep 4, 2024
Merged
bitcoind: Use project bitcoind in tests #2760
HenrikJannsen
merged 11 commits into
bisq-network:main
from
alvasw:use_project_bitcoind_in_tests
Sep 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field was added in Bitcoin Core 24.0.1.
This field was added in Bitcoin Core 24.0.1.
This option was added in Bitcoin Core 25.0.
This field was added in Bitcoin Core 25.0.
The `warning` string was replaced by a `warnings` JSON array in Bitcoin Core 25.0.
Bitcoin Core 25.0 deprecates support for legacy BDB wallets.
This field was added in Bitcoin Core 26.0.
This field was added in Bitcoin Core 26.0.
The tests use the installed bitcoind binary. To make the test failures reproducible it's better to run the tests with the officially supported Bitcoin Core version.
HenrikJannsen
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests use the installed bitcoind binary. To make the test failures
reproducible it's better to run the tests with the officially supported
Bitcoin Core version.