Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 63 #1638

Open
alvasw opened this issue Oct 10, 2024 · 2 comments
Open

For Cycle 63 #1638

alvasw opened this issue Oct 10, 2024 · 2 comments
Milestone

Comments

@alvasw
Copy link

alvasw commented Oct 10, 2024

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 8379.89
  • USD requested: 15000
  • BSQ rate: 1.79 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 62 #1613

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
bisq2: bitcoind: Extract Bisq 2 dependencies to wallet module dev bisq-network/bisq2#2802
bisq2: wallets: Remove dependency to Bisq 2 Coin Class dev bisq-network/bisq2#2803

We can't depend on Bisq 2's Coin class to be able to reuse the wallets
library in Bisq 1.

bisq2: wallets: Remove dependency to Bisq 2 Hex Class dev bisq-network/bisq2#2811

We can't depend on Bisq 2's Hex class to be able to reuse the wallets library in Bisq 1.

bisq2: wallets: Remove dependency to Bisq 2 Threading Class dev bisq-network/bisq2#2812

We can't depend on Bisq 2's Threading class to be able to reuse the wallets library in Bisq 1.

bisq2: wallets: Remove dependency to Bisq 2 NetworkUtils Class dev bisq-network/bisq2#2813

We can't depend on Bisq 2's NetworkUtils class to be able to reuse the wallets library in Bisq 1.

bisq2: wallets: Remove dependency to Bisq 2 StringUtils Class dev bisq-network/bisq2#2814

We can't depend on Bisq 2's StringUtils class to be able to reuse the wallets library in Bisq 1.

bisq2: wallets: Remove dependency to Bisq 2 FileUtils Class dev bisq-network/bisq2#2815

We can't depend on Bisq 2's FileUtils class to be able to reuse the
wallets library in Bisq 1.

bisq2: Move Scanners to bisq.wallets.regtest module dev bisq-network/bisq2#2816

We can't depend on Bisq 2's common module to be able to reuse the
wallets library in Bisq 1.

bisq2: gradle-tasks: Remove dependency to Bisq 2 common module dev bisq-network/bisq2#2823

We can't depend on Bisq 2's common module to be able to reuse the wallets library in Bisq 1.

bisq2: Move gradle-tasks module to bitcoind module dev bisq-network/bisq2#2824
bisq2: Move bitcoin-core-binaries module to bitcoind module dev bisq-network/bisq2#2825
bisq2: Create bitcoind specific RpcConfig dev bisq-network/bisq2#2844
bisq2: Move WalletService into Bisq 2 specific code dev bisq-network/bisq2#2845
bisq2: Downgrade bitcoind to Java 11 dev bisq-network/bisq2#2846
bisq2: DaemonProcess: Remove Bisq 2 dependency dev bisq-network/bisq2#2847
bisq2: bitcoind.Os: Remove Bisq 2 dependency dev bisq-network/bisq2#2848
bisq2: Remove bitcoind's dependency to root build-logic module dev bisq-network/bisq2#2849

We can't depend on Bisq 2's build-logic module to be able to reuse the
wallets library in Bisq 1.

bisq2: bitcoind: Set build-logic name to bitcoind-build-logic dev bisq-network/bisq2#2917
bisq2: Remove protobuf dependency from bitcoind modules dev bisq-network/bisq2#2910
bisq2: electrum: Reuse code from bitcoind module dev bisq-network/bisq2#2911
bisq2: packaging: Remove dependency to Bisq 2 commons module dev bisq-network/bisq2#2912
bisq2: bitcoind-build-logic: Remove unused protobuf dependency dev bisq-network/bisq2#2913
bisq2: bitcoind: Remove dependency to root build-logic dev bisq-network/bisq2#2914
bisq2: bitcoind: Remove dependency to root version catalog dev bisq-network/bisq2#2915
bisq2: bitcoind: Reference gradle-tasks module locally dev bisq-network/bisq2#2916
bisq2: bitcoind: Use toLowerCase() instead of lowercase() dev bisq-network/bisq2#2918

Bisq 1's Kotlin version is older than 1.5.

bisq2: BitcoindRegtestProcess: Expose P2P port number dev bisq-network/bisq2#2919

BitcoinJ connects to Bitcoin Core's P2P port. Up to now, we selected a
random port without saving the p2p port number.

bisq2: BitcoindRegtestProcess: Support peer bloom filters dev bisq-network/bisq2#2920

BitcoinJ relies on connects to Bitcoin Core's peer bloom filters.

bisq2: build: Remove compileJava.options.release dev bisq-network/bisq2#2921

The java toolchain is already set to 22.

User support (log analysis, assisting users in fixing their issues) dev
dev 15000 Total for items above.
@alvasw
Copy link
Author

alvasw commented Oct 10, 2024

c64978ba30f8e551311dc89b76341877fb7258b2a11d365b138644515e790885

@MwithM MwithM added this to the Cycle 63 milestone Oct 12, 2024
@MwithM MwithM moved this to In Review in Compensation Request Board Oct 12, 2024
@MwithM MwithM moved this from In Review to Proposal Submitted in Compensation Request Board Oct 21, 2024
@MwithM
Copy link
Contributor

MwithM commented Oct 21, 2024

Accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Proposal Submitted
Development

No branches or pull requests

2 participants