bitcoind: Remove the 'wait until blocks mined' functionality #2747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We send a `stop` RPC call and wait for the subprocess after receiving a `success/ok` message. This is unnecessary because we received a `success` reply already.
We parse stdout and wait for the "init message: Done loading" line to detect when bitcoind is ready. After seeing this line, we stop reading stdout causing the stdout buffer to fill up. When the stdout buffer fills up, bitcoind waits until its parent process reads from it but this unfortunately never happens leading to a deadlock.
The assumptions and expectations of the tests are wrong.
The test mines blocks and waits until it sees the block hashes of the mined blocks over ZMQ. Unfortunately, ZMQ publishers are stateless and can't re-transmit lost messages [1]. Consequently, the test was wrong. The fixed test subscribes to the publisher, starts mining blocks, and waits until it observes a new block hash. [1] https://zguide.zeromq.org/docs/chapter5/#Pros-and-Cons-of-Pub-Sub
The assumptions and expectations of the tests are wrong.
The implementation is wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation is wrong.