Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations for v2.1.1 #2754

Merged

Conversation

hiciefte
Copy link
Contributor

@hiciefte hiciefte commented Sep 3, 2024

Besides translations I also fixed a truncation issue in languages with longer strings than in the English source

Before
Bildschirmfoto 2024-09-03 um 11 07 07

After
Bildschirmfoto 2024-09-03 um 11 05 33

Unfortunately it wasn't possible to solve this by using Hbox growth priorities.

@hiciefte
Copy link
Contributor Author

hiciefte commented Sep 3, 2024

In this update I also went through all warnings on Transifex, so I hope any inconsistencies should be fixed now 🤞

@HenrikJannsen
Copy link
Contributor

HenrikJannsen commented Sep 3, 2024

Did you use the latest commit version? There have been recent changes. Mostly in reputation and user files.
Regarding the market list truncation: Have you tried to reduce the right padding? I guess that can be reduces to avoid truncation.
An alternative would be to use either TextFlowUtils[1] to use a smaller font (maybe even a darker color) for the number of offers text, or to make a custom HBox with TextFlow or just 2 labels.

[1] Example:
bisqEasy.tradeWizard.review.price={0} <{1} style=trade-wizard-review-code>

@hiciefte
Copy link
Contributor Author

hiciefte commented Sep 4, 2024

Did you use the latest commit version? There have been recent changes. Mostly in reputation and user files. Regarding the market list truncation: Have you tried to reduce the right padding? I guess that can be reduces to avoid truncation. An alternative would be to use either TextFlowUtils[1] to use a smaller font (maybe even a darker color) for the number of offers text, or to make a custom HBox with TextFlow or just 2 labels.

[1] Example: bisqEasy.tradeWizard.review.price={0} <{1} style=trade-wizard-review-code>

Yes, I pulled main yesterday before I pushed the PR. I'll de-couple the fix from the translations and will look at the different options to solve this issue

@hiciefte hiciefte force-pushed the update-translations-for-v2.1.1 branch from c73d557 to 33e3cfe Compare September 4, 2024 06:45
Copy link
Contributor

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@HenrikJannsen HenrikJannsen merged commit 570768e into bisq-network:main Sep 4, 2024
21 checks passed
@HenrikJannsen HenrikJannsen added this to the 2.1.2 milestone Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants