Add toggle for displaying volume in tradestatistics chart in USD #5066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Volume was created at each access from amount and price. To improve performance we cache the result once calculated.
Precalculate the USD average prices for tick intervals and use that for converting the BTC volume to USD volume.
|
Does it have to be USD? 😅 |
|
It need to be fiat currency sufficiently trades, so EUR or USD are the only one which always got some volume. We calculate the historical price based on those trades. The calculation is a bit expensive so I dont want to do it for multiple currencies. Also for most USD price is kind of the main price metric. Does not mean any endoresement of USD of course - the biggest shitcoin in fiat land. ;-) |
Fix incorrect removeListener call on priceColumn.textProperty() instead of priceColumnLabel
changed or we got added new trade stats
This was referenced Jan 9, 2021
Closed
|
Glad to see this feature. I just tweeted about it here: https://twitter.com/cbeams/status/1357298837052866560, and added a a follow-on feature request at #5154. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a toggle to show trade statistics volume in USD instead of BTC