Improve cleanup tor dir at seeds #5070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Volume was created at each access from amount and price. To improve performance we cache the result once calculated.
Precalculate the USD average prices for tick intervals and use that for converting the BTC volume to USD volume.
Fix incorrect removeListener call on priceColumn.textProperty() instead of priceColumnLabel
changed or we got added new trade stats
We cannot clear it now as Tor is used and that can cause problems.
sqrrm
approved these changes
Jan 12, 2021
| @@ -116,7 +117,7 @@ | |||
| final int maxTicks = 90; | |||
| private int selectedTabIndex; | |||
| final Map<TickUnit, Map<Long, Long>> usdPriceMapsPerTickUnit = new HashMap<>(); | |||
|
|
|||
| private boolean fillTradeCurrenciesOnActiavetCalled; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If all connections lost at seed nodes we clean tor cache files and trigger a restart.
We set a flag to clear tor cache files at shutdown and at startup we check for that flag and clean the tor cache before tor is started. Before we did that at shutdown but that can cause problems as tor is running at that moment.
Based on #5066 (to avoid merge conflicts, as we added an entry to CookieKey there)
PR starts at 8ecfa8b