Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to chart trade statistics in terms of number of trades #5154

Closed
cbeams opened this issue Feb 4, 2021 · 3 comments
Closed

Add option to chart trade statistics in terms of number of trades #5154

cbeams opened this issue Feb 4, 2021 · 3 comments

Comments

@cbeams
Copy link
Contributor

cbeams commented Feb 4, 2021

This is a follow on to the feature released in v1.5.5 that allow charting USD-denominated trade volumes (#5066).

Ideally, we would allow three options for charting trade statistics:

  1. Trade volume in BTC (current default)
  2. Trade volume in USD (new option in v1.5.5)
  3. Number of trades (proposed new option)

I tweeted about this at https://twitter.com/cbeams/status/1357298837052866560, here's a screenshot:

image

The graph shown in the lower tweet is available at https://docs.google.com/spreadsheets/d/1o-I5fAx7DJRVqYjW8fPbo0ztlGIhIZ1EM2iLc5aEHnA/edit#gid=86481090 (not currently publicly available)

I see the number of trades per month as one of Bisq's best health metrics. It keeps growing, it's a positive story, and it's a missed opportunity not to show this more prominently to users.

This could be implemented by offer three radio buttons above the chart instead of a toggle slider, e.g.:

[ ] Show volume in BTC [ ] Show volume in USD [x] Show number of trades

@chimp1984
Copy link
Contributor

I will soon have a PR with an improved chart component. So maybe worth to wait for that and use that then as base to extend the feature... Any dev welcome to pick that up...

@stale
Copy link

stale bot commented Jun 11, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Jun 11, 2021
@stale
Copy link

stale bot commented Jun 22, 2021

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@stale stale bot closed this as completed Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants