Refactor http client #4942
Merged
Refactor http client #4942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use HttpMethod as param Add getHttpUriRequest method
while hasPendingRequest is true - Throw exception if we get a request before previous request is terminated (happens with priceFee at startup, on regtest as startup is fast, but can happen also on mainnet) - Improve shutDown - Improve finally clause
We used the same HttpClient for fee and price requests, which cause problems when one request got completed and closed the connection at finalize.
ripcurlx
approved these changes
Dec 14, 2020
|
utACK I thumbs up for the well scoped commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors and fixes HttpClient
Add support for POST (Needed for follow up PR)
Do not allow multiple requests before one request is completed
Use different httpClients for getFee and getPrice