Code

Refactor http client#4942

Code

Merged

ripcurlx merged 21 commits intobisq-network:masterbisq-network/bisq:masterfrom chimp1984:refactor-http-clientchimp1984/bisq:refactor-http-clientCopy head branch name to clipboardDec 14, 2020

+241-99

Commits

Commits on Dec 13, 2020

• Use Lombok setter and getters

  chimp1984

  committed
  8122cab

• Update toString method

  chimp1984

  committed
  4c81c44

• Remove requestWithGETNoProxy methods from interface (not used outside)

  chimp1984

  committed
  77f46a0

• Refactor: Extract method getSocks5Proxy

  chimp1984

  committed
  3a2e4f1

• Refactor getSocks5Proxy method: Return early, make flow more clear

  chimp1984

  committed
  7f85fd9

• Rearrange: move method down

  chimp1984

  committed
  138019e

• Add HttpMethod enum

  Show description for b480f26
  chimp1984

  committed
  b480f26

• Add baseUrl as param, extract variable

  chimp1984

  committed
  b9d72b5

• Improve logging

  chimp1984

  committed
  5a1a900

• Rename httpclient (make it more distinct to Bisq Httpclient)

  chimp1984

  committed
  3cf97c7

• Add post method. Add doRequest method

  chimp1984

  committed
  de2ba82

• Refactor: Rename 'requestWithGET' to 'get'

  chimp1984

  committed
  9496691

• - Add hasPendingRequest() getter and block repeated requests

  Show description for d61a07f
  chimp1984

  committed
  d61a07f

• Check if we have a pending request and return if thats the case

  chimp1984

  committed
  561639f

• Use dedicated HttpClient for fee requests

  Show description for 5be2ea5
  chimp1984

  committed
  5be2ea5

• Fix incorrect checkArgument

  chimp1984

  committed
  3b0ad35

• Improve logs

  chimp1984

  committed
  5d664e9

• Use @singleton annotation instead of definition in module

  chimp1984

  committed
  3d8d445

• Rename PriceNodeHttpClient to PriceHttpClient

  chimp1984

  committed
  f7790a6

• Improve thread name

  chimp1984

  committed
  06ce1b6

• Improve log

  chimp1984

  committed
  ad2a329