Use existing timer in unlockwallet(pwd, timeout) #4558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bats version check tests now use a bash script for parsing the value from the Bisq class file, and these test cases no longer need to be manually updated.
The string constants deleted from the test case are re-defined as enums, but the test harness still passes around strings (enum.name()) because the handling of invalid dispute agent type string args needs to be tested. (Reminder: CLI does not accept any enum arguments.)
And make test dispute agent registration work from static fixture setup methods.
cd2357
reviewed
Sep 24, 2020
chimp1984
reviewed
Sep 25, 2020
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@ghubstan Is that PR still relevant or has it been adding in other PRs already? |
It is still relevant, but I will add to cleaner PR, then close this. I'd like to keep it open until then. |
ghubstan
added a commit
to ghubstan/bisq
that referenced
this pull request
Oct 31, 2020
This change was requested in chimp1984@961703e This replaces and closes PR bisq-network#4558
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the changes @chimp1984 requested in chimp1984@961703e.
(This PR depends on 4554.)