Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use existing timer in unlockwallet(pwd, timeout) #4558

Closed
wants to merge 15 commits into from
Closed

Use existing timer in unlockwallet(pwd, timeout) #4558

wants to merge 15 commits into from

Commits on Sep 22, 2020

  1. Replace hardcoded version with Version.java value 

    Bats version check tests now use a bash script for parsing
the value from the Bisq class file, and these test cases
no longer need to be manually updated.
    @ghubstan
    ghubstan committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    9132722 View commit details
    Browse the repository at this point in the history

  2. Remove comment

    @ghubstan
    ghubstan committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    34cfe95 View commit details
    Browse the repository at this point in the history

  3. Move test dispute agent type constants to core 

    The string constants deleted from the test case are re-defined as enums,
but the test harness still passes around strings (enum.name()) because
the handling of invalid dispute agent type string args needs to be
tested.  (Reminder:  CLI does not accept any enum arguments.)
    @ghubstan
    ghubstan committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    8896372 View commit details
    Browse the repository at this point in the history

  4. Fix indentation

    @ghubstan
    ghubstan committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    1f307c8 View commit details
    Browse the repository at this point in the history

  5. Add simple create payment acct test 

    And make test dispute agent registration work from static fixture
setup methods.
    @ghubstan
    ghubstan committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    6a50402 View commit details
    Browse the repository at this point in the history

  6. Remove final modifiers

    @ghubstan
    ghubstan committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    1d88d27 View commit details
    Browse the repository at this point in the history

  7. Don't use static boilerplate helpers if not necessary

    @ghubstan
    ghubstan committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    c4dd041 View commit details
    Browse the repository at this point in the history

  8. Remove comment

    @ghubstan
    ghubstan committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    e63a6c5 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2020

  1. Add get default payment acct helper

    @ghubstan
    ghubstan committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    92f36ed View commit details
    Browse the repository at this point in the history

  2. Stub out createoffer method in CLI

    @ghubstan
    ghubstan committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    2b68e57 View commit details
    Browse the repository at this point in the history

  3. Change API's createoffer return value from bool to Offer

    @ghubstan
    ghubstan committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    3c0c443 View commit details
    Browse the repository at this point in the history

  4. Add API CreateOfferTest case

    @ghubstan
    ghubstan committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    70e3be0 View commit details
    Browse the repository at this point in the history

  5. Fix imports

    @ghubstan
    ghubstan committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    fc1f0ba View commit details
    Browse the repository at this point in the history

  6. Fix unnecessary use of fully qualified name

    @ghubstan
    ghubstan committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    d190d09 View commit details
    Browse the repository at this point in the history

  7. Use existing timer in unlockwallet(pwd, timeout)

    @ghubstan
    ghubstan committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    939dba3 View commit details
    Browse the repository at this point in the history