Change 'createoffer' api method return type #4554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bats version check tests now use a bash script for parsing the value from the Bisq class file, and these test cases no longer need to be manually updated.
The string constants deleted from the test case are re-defined as enums, but the test harness still passes around strings (enum.name()) because the handling of invalid dispute agent type string args needs to be tested. (Reminder: CLI does not accept any enum arguments.)
And make test dispute agent registration work from static fixture setup methods.
ghubstan
changed the title
|
This PR partially addresses the |
This was referenced Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the existing gRPC
createoffermethod to return the new Offer instead of a boolean. Althoughcreateofferstill places the offer, it might be changed to give the user a chance to examine a newly created (and cached) offer before it is placed in a separateconfirmoffer offer-idorplaceoffer offer-idmethod.An api test case was added and the CLI's
createoffermethod was stubbed out -- to be implemented in another PR.Several unrelated, minor changes were pushed before the most relevant ones.
(This PR should be reviewed/merged before 4558 and 4559.)