Fix weird bug with svg images on /index #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems the SVGs used for screenshots on the front page did not behave consistently across OSes. Testing indicated no issues on multiple browsers on Ubuntu, but testing on macOS indicated SVG font properties were not being applied correctly. Images were PNGs before, and there was no particular need to switch to SVG, so this commit switches them back to PNG. The switch was initially made in bisq-network#278 to produce translated screenshots. SVG files remain in the repository as "source" for the PNG files.
cbeams
approved these changes
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address #295.
Issue seems to be OS-related, as it was introduced with #278, and only seems to occur on macOS (which explains why I never saw the issue when reviewing).
I don't deem it worthwhile to debug, so I've just switched all screenshots back to PNG. SVG files remain in the repository as "source" files in case the PNGs need to be updated later.
Please review this PR on macOS or Windows, as the issue never occurred on Linux.
https://deploy-preview-304--bisq-website.netlify.com/