-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and optimize image alt tags for better SEO #321
Conversation
This will boost traffic and SEO (Search Engine Optimization) for Bisq.network.
@RiccardoMasutti these are good edits, but the Hence my other PR #279 to get rid of that page altogether...review appreciated :) As for this PR, the changes should be made in the other files that are actually rendered like I know this isn't intuitive...refactoring is needed. |
@m52go ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NACK - see comment.
@m52go ty for review. fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small nits such as "Redhat" --> "Red Hat".
But bigger issues are more concerning: a number of images were changed when they shouldn't have been changed. This PR wasn't supposed to change image links at all -- please keep PRs focused on the declared changes. I assume these were inadvertent on your part, but for me as reviewer, identifying and correcting such changes is unexpected and time-consuming. I'm still not sure I caught all of them.
Please consider diffing your changes next time before submitting to verify nothing unintended has crept in...and of course, it's critical that you set up a testing environment if you haven't already (feel free to reach out if you're not familiar with what I'm talking about).
Co-Authored-By: Steve Jain <[email protected]>
Co-Authored-By: Steve Jain <[email protected]>
Co-Authored-By: Steve Jain <[email protected]>
Co-Authored-By: Steve Jain <[email protected]>
Co-Authored-By: Steve Jain <[email protected]>
Co-Authored-By: Steve Jain <[email protected]>
Co-Authored-By: Steve Jain <[email protected]>
Co-Authored-By: Steve Jain <[email protected]>
Co-Authored-By: Steve Jain <[email protected]>
Co-Authored-By: Steve Jain <[email protected]>
Co-Authored-By: Steve Jain <[email protected]>
Co-Authored-By: Steve Jain <[email protected]>
Co-Authored-By: Steve Jain <[email protected]>
Co-Authored-By: Steve Jain <[email protected]>
Co-Authored-By: Steve Jain <[email protected]>
Co-Authored-By: Steve Jain <[email protected]>
Co-Authored-By: Steve Jain <[email protected]>
Co-Authored-By: Steve Jain <[email protected]>
Co-Authored-By: Steve Jain <[email protected]>
Co-Authored-By: Steve Jain <[email protected]>
@RiccardoMasutti there was still a mistake. Testing in your local browser would easily help find these kinds of issues. |
ACK |
This will boost traffic and SEO (Search Engine Optimization) for Bisq.network.
It's extremely important to give images good alt attributes: alt text strengthens the message of website pages with search engine spiders and improves the accessibility of it.