Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and optimize image alt tags for better SEO #321

Merged
merged 34 commits into from
Jan 27, 2020

Conversation

RiccardoMasutti
Copy link
Contributor

This will boost traffic and SEO (Search Engine Optimization) for Bisq.network.

It's extremely important to give images good alt attributes: alt text strengthens the message of website pages with search engine spiders and improves the accessibility of it.

This will boost traffic and SEO (Search Engine Optimization) for Bisq.network.
@m52go
Copy link
Contributor

m52go commented Jan 3, 2020

@RiccardoMasutti these are good edits, but the index.html page is never actually rendered to the user, so these edits won't ever take effect.

Hence my other PR #279 to get rid of that page altogether...review appreciated :)

As for this PR, the changes should be made in the other files that are actually rendered like homepage_content.html, os_selector_options.html, etc.

I know this isn't intuitive...refactoring is needed.

@RiccardoMasutti
Copy link
Contributor Author

@m52go ready to merge

Copy link
Contributor

@m52go m52go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK - see comment.

_includes/homepage_content.html Outdated Show resolved Hide resolved
@RiccardoMasutti
Copy link
Contributor Author

@m52go ty for review. fixed

Copy link
Contributor

@m52go m52go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits such as "Redhat" --> "Red Hat".

But bigger issues are more concerning: a number of images were changed when they shouldn't have been changed. This PR wasn't supposed to change image links at all -- please keep PRs focused on the declared changes. I assume these were inadvertent on your part, but for me as reviewer, identifying and correcting such changes is unexpected and time-consuming. I'm still not sure I caught all of them.

Please consider diffing your changes next time before submitting to verify nothing unintended has crept in...and of course, it's critical that you set up a testing environment if you haven't already (feel free to reach out if you're not familiar with what I'm talking about).

_includes/homepage_content.html Outdated Show resolved Hide resolved
_includes/homepage_content.html Outdated Show resolved Hide resolved
_includes/homepage_content.html Outdated Show resolved Hide resolved
_includes/homepage_content.html Outdated Show resolved Hide resolved
_includes/homepage_content.html Outdated Show resolved Hide resolved
_includes/homepage_content_tr.html Outdated Show resolved Hide resolved
_includes/homepage_content_tr.html Outdated Show resolved Hide resolved
_includes/os_selector_options.html Outdated Show resolved Hide resolved
_includes/os_selector_options.html Outdated Show resolved Hide resolved
_includes/os_selector_options.html Outdated Show resolved Hide resolved
@m52go
Copy link
Contributor

m52go commented Jan 27, 2020

@RiccardoMasutti there was still a mistake. Testing in your local browser would easily help find these kinds of issues.

Screenshot from 2020-01-27 16-16-31

@m52go
Copy link
Contributor

m52go commented Jan 27, 2020

ACK

@m52go m52go merged commit 9b5bdbe into bisq-network:master Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants