Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

part 1: review/add Translator resources to BTE's API list #865

Closed
andrewsu opened this issue Sep 12, 2024 · 6 comments
Closed

part 1: review/add Translator resources to BTE's API list #865

andrewsu opened this issue Sep 12, 2024 · 6 comments
Assignees
Labels
data source On Test Related changes are deployed to Test server

Comments

@andrewsu
Copy link
Member

Long ago we made a principled decision that we would use an API allow list to define what resources BTE would include. We should revisit that decision to make sure we still agree that's the right choice. And if so, we should review resources that are not currently being called by BTE for possible inclusion in our API allow list.

@colleenXu
Copy link
Collaborator

colleenXu commented Sep 25, 2024

UPDATE:

I made a minimal list of APIs BTE isn't using right now. This includes TRAPI KPs and APIs with x-bte that are also tagged translator.

We decided to...

Try adding 5 TRAPI KPs that I was able to retrieve edges from thru BTE in manual testing: biothings/bte-server#43

Considering, see Part 2...

Wait on...

Don't add (for now): The in-limbo APIs with x-bte

@colleenXu
Copy link
Collaborator

colleenXu commented Oct 3, 2024

Marc Duby has reported that Genetics KP CI has a fix for knowledge_types (Translator Slack). I haven't checked yet.

I'm assuming adding this KP would be for the next sprint, not this one...

@tokebe
Copy link
Member

tokebe commented Oct 3, 2024

Yeah, I don't think we want to rush adding new KPs...

@colleenXu colleenXu changed the title review translator resources in smartAPI for inclusion in BTE's API list part 1: review/add Translator resources to BTE's API list Oct 14, 2024
@colleenXu
Copy link
Collaborator

colleenXu commented Oct 14, 2024

This issue is to track the 5 KPs we did add to BTE #865 (comment)

@colleenXu colleenXu added the On CI Related changes are deployed to CI server label Oct 14, 2024
@colleenXu
Copy link
Collaborator

colleenXu commented Oct 22, 2024

Given urgent issues with BTE timeouts: going to remove MolePro. Queries to it timeout often, and adds wait time. And we may be querying it more with the record limit, parallel features. biothings/bte-server#49

Already adjusted main comment

@colleenXu colleenXu added On CI -> Test and removed On CI Related changes are deployed to CI server labels Oct 24, 2024
@tokebe tokebe added On Test Related changes are deployed to Test server and removed On CI -> Test labels Oct 28, 2024
@tokebe
Copy link
Member

tokebe commented Dec 3, 2024

Related changes deployed to Prod as of 11/13

@tokebe tokebe closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data source On Test Related changes are deployed to Test server
Projects
None yet
Development

No branches or pull requests

3 participants