Add pephub prefix #1194
Merged
Add pephub prefix #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthoyt
reviewed
Oct 9, 2024
|
@nagutm let's add the publication info and then this should be good to go |
cthoyt
added
Prefix
New
|
Checked this again, everything looks good to me so I added reviewer info. |
added 2 commits
October 21, 2024 13:42
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1194 +/- ##
==========================================
+ Coverage 42.51% 43.56% +1.05%
==========================================
Files 117 118 +1
Lines 8327 8176 -151
Branches 1963 1343 -620
==========================================
+ Hits 3540 3562 +22
+ Misses 4582 4450 -132
+ Partials 205 164 -41 ☔ View full report in Codecov by Sentry. |
cthoyt
added a commit
that referenced
this pull request
Oct 25, 2024
This pull request updates the `curated_papers.tsv` file with all PubMed papers identified till 2024-10-01 in #1165. Here are some statistics about the classification of each paper based on relevancy_type so far: **Relevant (1) classifications: 14** - new_prefix: 3 - new_provider: 4 - new_publication: 2 - unclear: 2** - existing: 3 **Irrelevant (0) classifications: 40** - irrelevant_other: 31 - no_website: 2 - not_identifiers_resource: 7 ** 1. [39104285](https://bioregistry.io/pubmed:39104285) is a provider for UniProt IDs but was not curated due to the variable nature of the `uri_format`. 2. [38991851](https://bioregistry.io/pubmed:38991851) was curated as a prefix but there was some discussion about whether it should be a provider instead. See #1194. Regardless, both of these were curated as relevant (1) which seems to be the more important classification. --------- Co-authored-by: Mufaddal Naguthanawala <[email protected]> Co-authored-by: Charles Tapley Hoyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to an ongoing discussion summarized in this comment: #1193 (comment) whether to include pephub as a prefix or a provider