Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curations to semi-automated literature workflow #1223

Merged
merged 10 commits into from
Oct 25, 2024

Conversation

nagutm
Copy link
Collaborator

@nagutm nagutm commented Oct 24, 2024

This pull request updates the curated_papers.tsv file with all PubMed papers identified till 2024-10-01 in #1165.

Here are some statistics about the classification of each paper based on relevancy_type so far:

Relevant (1) classifications: 14

  • new_prefix: 3
  • new_provider: 4
  • new_publication: 2
  • unclear: 2**
  • existing: 3

Irrelevant (0) classifications: 40

  • irrelevant_other: 31
  • no_website: 2
  • not_identifiers_resource: 7

** 1. 39104285 is a provider for UniProt IDs but was not curated due to the variable nature of the uri_format. 2. 38991851 was curated as a prefix but there was some discussion about whether it should be a provider instead. See #1194. Regardless, both of these were curated as relevant (1) which seems to be the more important classification.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.49%. Comparing base (8950e70) to head (91c6dd8).
Report is 112 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1223      +/-   ##
==========================================
+ Coverage   42.51%   43.49%   +0.97%     
==========================================
  Files         117      118       +1     
  Lines        8327     8190     -137     
  Branches     1963     1346     -617     
==========================================
+ Hits         3540     3562      +22     
+ Misses       4582     4464     -118     
+ Partials      205      164      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cthoyt
Copy link
Member

cthoyt commented Oct 24, 2024

Hi @nagutm, please do a bit of reading on writing good pull requests before making your next issue/pull request. It's difficult to keep up with so many that are not descriptive, full of typos, etc.

Some suggested resources:

  1. https://github.blog/developer-skills/github/how-to-write-the-perfect-pull-request/
  2. https://devdocs.prestashop-project.org/8/contribute/contribution-guidelines/pull-requests/
  3. https://www.ssw.com.au/rules/write-a-good-pull-request/

@nagutm
Copy link
Collaborator Author

nagutm commented Oct 24, 2024

Per #1227 (comment), I have updated the value of the pr_added field to reflect what pull request # the row in curated_papers.tsv was added.

@nagutm nagutm changed the title Update TSV Update curated_papers.tsv with all papers identified till 2024-10-01 Oct 24, 2024
@cthoyt cthoyt changed the title Update curated_papers.tsv with all papers identified till 2024-10-01 Add curations to semi-automated literature workflow Oct 25, 2024
@cthoyt cthoyt merged commit 98fcdb6 into biopragmatics:main Oct 25, 2024
15 checks passed
@nagutm nagutm deleted the update_tsv branch October 28, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants