Update cramino to 0.15.0 #51900
Update cramino to 0.15.0 #51900
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces updates to the Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Error: |
trying something I saw on twitter
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
recipes/cramino/meta.yaml (1)
Line range hint
17-25: Add clang/llvm dependency to fix build errorThe build is failing due to missing libclang, which is required by bindgen. This needs to be addressed by adding clang/llvm to the build requirements.
Apply this diff to fix the build error:
requirements: build: - {{ compiler('c') }} - {{ compiler('rust') }} - {{ compiler('cxx') }} + - clangdev + - llvmdev - rust >=1.60 - cmake - make - opensslThis should resolve the error:
thread 'main' panicked at [...] Unable to find libclang [...]
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
recipes/cramino/meta.yaml(2 hunks)
🧰 Additional context used
🪛 yamllint
recipes/cramino/meta.yaml
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
🔇 Additional comments (3)
recipes/cramino/meta.yaml (3)
Line range hint 1-5: LGTM: Version update looks correct
The version bump from 0.14.5 to 0.15.0 is properly reflected in the package metadata.
🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
Line range hint 7-11: LGTM: Build configuration is appropriate
Build number reset to 0 is correct for a version bump, and the run exports configuration is properly maintained.
🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
13-15: Verify the source archive checksum
The source URL and checksum have been updated for the new version.
the rabbit told me
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
recipes/cramino/meta.yaml(2 hunks)
🧰 Additional context used
🪛 yamllint
recipes/cramino/meta.yaml
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
🔇 Additional comments (3)
recipes/cramino/meta.yaml (3)
1-1: LGTM: Version update matches PR objective.
The version bump to 0.15.0 aligns with the PR's purpose.
🧰 Tools
🪛 yamllint
[error] 1-1: syntax error: found character '%' that cannot start any token
(syntax)
15-15: LGTM: SHA256 checksum updated.
The new SHA256 checksum has been properly updated for the 0.15.0 release tarball.
20-24: Verify rust compiler compatibility.
The requirement rust >=1.60 seems appropriate, but let's verify it's sufficient for the new version's build dependencies.
| - {{ compiler('rust') }} | ||
| - {{ compiler('cxx') }} | ||
| - clangdev | ||
| - llvmdev |
There was a problem hiding this comment.
Address the libclang dependency issue.
The build error reported in the PR comments indicates missing libclang libraries. While you've added clangdev and llvmdev as build requirements, there might be additional configuration needed.
Consider these solutions:
- Add
LIBCLANG_PATHto build environment:
build:
number: 0
skip: true # [osx]
+ script_env:
+ - LIBCLANG_PATH=$PREFIX/lib- Alternatively, ensure proper linking by adding:
build:
number: 0
skip: true # [osx]
+ missing_dso_whitelist:
+ - "$RPATH/libclang.so.*"Committable suggestion skipped: line range outside the PR's diff.
Update
cramino: 0.14.5 → 0.15.0recipes/cramino(click to view/edit other files)This pull request was automatically generated (see docs).