Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cramino to 0.15.0 #51900

Merged
merged 3 commits into from
Nov 4, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions recipes/cramino/meta.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{% set version = "0.14.5" %}
{% set version = "0.15.0" %}

package:
name: cramino
Expand All @@ -12,11 +12,15 @@ build:

source:
url: https://github.com/wdecoster/cramino/archive/v{{ version }}.tar.gz
sha256: d3b31ab76808ca76171e2539cfe30e66fe24cbd4af4ff9a941c282a0bc438032
sha256: 731d4232e8a5503f704825b04e8ff081294381a1324fec3e59771ca773c68465

requirements:
build:
- {{ compiler('c') }}
- {{ compiler('rust') }}
- {{ compiler('cxx') }}
- clangdev
- llvmdev
- rust >=1.60
Comment on lines +20 to +23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Address the libclang dependency issue.

The build error reported in the PR comments indicates missing libclang libraries. While you've added clangdev and llvmdev as build requirements, there might be additional configuration needed.

Consider these solutions:

  1. Add LIBCLANG_PATH to build environment:
  build:
    number: 0
    skip: true  # [osx]
+   script_env:
+     - LIBCLANG_PATH=$PREFIX/lib
  1. Alternatively, ensure proper linking by adding:
  build:
    number: 0
    skip: true  # [osx]
+   missing_dso_whitelist:
+     - "$RPATH/libclang.so.*"

Committable suggestion skipped: line range outside the PR's diff.

- cmake
- make
Expand Down
Loading