-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update GHA artifact location #51728
Conversation
📝 WalkthroughWalkthroughThe changes in this pull request involve updates to the GitHub Actions workflow configuration in the Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (1)
.github/workflows/PR.yml (1)
138-138
: Maintain consistent artifact directory structure across jobs.The current changes appear to break the existing artifact organization rather than fix it. Consider:
The prepare steps in both jobs maintain a structured approach with subdirectories:
/tmp/artifacts/packages
for package artifacts/tmp/artifacts/images
for Docker images (in Linux build)Changing upload paths to
/tmp/artifacts
loses this organization and could affect:
- Artifact discovery by downstream processes
- Separation of different artifact types
- Consistency across different build jobs
Recommendation: Keep the structured approach by maintaining specific subdirectories in the upload paths.
Also applies to: 211-211
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- .github/workflows/PR.yml (2 hunks)
- recipes/lima/meta.yaml (1 hunks)
✅ Files skipped from review due to trivial changes (1)
- recipes/lima/meta.yaml
@BiocondaBot please fetch artifacts |
Package(s) built are ready for inspection:
|
The expected artifact directory structure changed slightly from last time GHA was used.
Use Lima as an example since it was merged to master but not uploaded.