Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update GHA artifact location #51728

Merged
merged 2 commits into from
Oct 28, 2024
Merged

ci: update GHA artifact location #51728

merged 2 commits into from
Oct 28, 2024

Conversation

aliciaaevans
Copy link
Contributor

The expected artifact directory structure changed slightly from last time GHA was used.

Use Lima as an example since it was merged to master but not uploaded.

Copy link
Contributor

coderabbitai bot commented Oct 28, 2024

📝 Walkthrough

Walkthrough

The changes in this pull request involve updates to the GitHub Actions workflow configuration in the .github/workflows/PR.yml file and minor modifications to the meta.yaml file for the lima package. The workflow updates include adjustments to artifact handling, specifically changing the path for stored artifacts from /tmp/artifacts/packages to /tmp/artifacts, thereby consolidating the storage location. The Archive images step in the build-linux job has been removed, indicating a change in Docker image management. The build-osx-64 job has been updated to reflect the new artifact path, while the build_and_test-osx-arm64 job remains commented out due to concurrency limitations on GitHub Actions. In the meta.yaml file for the lima package, a minor formatting change was made by adding a space after the comment #repackaged binary, with no impact on functionality or logic.

Possibly related PRs

Suggested reviewers

  • bgruening: Suggested reviewer for the changes made in the pull request.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Outside diff range and nitpick comments (1)
.github/workflows/PR.yml (1)

138-138: Maintain consistent artifact directory structure across jobs.

The current changes appear to break the existing artifact organization rather than fix it. Consider:

  1. The prepare steps in both jobs maintain a structured approach with subdirectories:

    • /tmp/artifacts/packages for package artifacts
    • /tmp/artifacts/images for Docker images (in Linux build)
  2. Changing upload paths to /tmp/artifacts loses this organization and could affect:

    • Artifact discovery by downstream processes
    • Separation of different artifact types
    • Consistency across different build jobs

Recommendation: Keep the structured approach by maintaining specific subdirectories in the upload paths.

Also applies to: 211-211

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 12b3152 and 4e1f3df.

📒 Files selected for processing (2)
  • .github/workflows/PR.yml (2 hunks)
  • recipes/lima/meta.yaml (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • recipes/lima/meta.yaml

.github/workflows/PR.yml Show resolved Hide resolved
.github/workflows/PR.yml Show resolved Hide resolved
@aliciaaevans
Copy link
Contributor Author

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Package(s) built are ready for inspection:

Arch Package Zip File / Repodata CI Instructions
linux-64 lima-2.12.0-h9ee0642_0.tar.bz2 linux-64.zip GitHub Actions
showYou may also use conda to install after downloading and extracting the zip file. conda install -c ./packages <package name>

@aliciaaevans aliciaaevans merged commit b81cc99 into master Oct 28, 2024
5 of 6 checks passed
@aliciaaevans aliciaaevans deleted the gha-artifact-location branch October 28, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants