-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Don't rename image filename #51729
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe pull request introduces modifications to the GitHub Actions workflow for pull request checks and updates the Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
recipes/libgff/meta.yaml (1)
Line range hint
39-42
: LGTM! Good platform coverage.The addition of ARM64 support for both Linux and macOS is a forward-thinking choice that ensures broader compatibility.
Consider testing the builds on these platforms to ensure all dependencies are available and the package builds successfully.
🧰 Tools
🪛 yamllint
[error] 31-31: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- .github/workflows/PR.yml (0 hunks)
- recipes/libgff/meta.yaml (1 hunks)
💤 Files with no reviewable changes (1)
- .github/workflows/PR.yml
🧰 Additional context used
🪛 yamllint
recipes/libgff/meta.yaml
[error] 31-31: trailing spaces
(trailing-spaces)
🔇 Additional comments (2)
recipes/libgff/meta.yaml (2)
Line range hint
32-37
: LGTM! Well-structured metadata section.The about section follows conda packaging best practices with complete metadata including license, summary, and relevant URLs.
🧰 Tools
🪛 yamllint
[error] 31-31: trailing spaces
(trailing-spaces)
Line range hint
1-42
: Verify alignment with PR objectives.The changes in this file appear unrelated to the PR's stated objective of preventing image filename renaming in CI. Let's verify if there are other relevant files that should be reviewed.
🧰 Tools
🪛 yamllint
[error] 31-31: trailing spaces
(trailing-spaces)
ok that's not going to work because it actually throws an error. Got to change it on the bioconda-utils side. |
Remove the line that gets rid of
:
in the filename since bioconda-utils uses that to get the image version.