Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Don't rename image filename #51729

Closed
wants to merge 3 commits into from
Closed

Conversation

aliciaaevans
Copy link
Contributor

Remove the line that gets rid of : in the filename since bioconda-utils uses that to get the image version.

Copy link
Contributor

coderabbitai bot commented Oct 28, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

The pull request introduces modifications to the GitHub Actions workflow for pull request checks and updates the meta.yaml file for the libgff package. The GitHub Actions workflow, named "PR Check," is triggered on events such as opening, synchronizing, and reopening pull requests. Key updates include concurrency settings that group builds by pull request number and allow cancellation of in-progress jobs. The workflow consists of three jobs: lint, build-linux, and build-osx-64, with dependencies ensuring that linting occurs before building. The lint job runs on Ubuntu and performs code checks, while the build-linux and build-osx-64 jobs handle building and testing on their respective platforms. Additionally, the meta.yaml file for libgff has been updated to increment the build number from 0 to 1, with no changes to other sections of the file.

Possibly related PRs

Suggested labels

please review & merge

Suggested reviewers

  • bgruening
  • mencian

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 429f2d9 and a3e5de0.

📒 Files selected for processing (1)
  • recipes/libgff/meta.yaml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • recipes/libgff/meta.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)
recipes/libgff/meta.yaml (1)

Line range hint 39-42: LGTM! Good platform coverage.

The addition of ARM64 support for both Linux and macOS is a forward-thinking choice that ensures broader compatibility.

Consider testing the builds on these platforms to ensure all dependencies are available and the package builds successfully.

🧰 Tools
🪛 yamllint

[error] 31-31: trailing spaces

(trailing-spaces)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 1cc8f9a and 429f2d9.

📒 Files selected for processing (2)
  • .github/workflows/PR.yml (0 hunks)
  • recipes/libgff/meta.yaml (1 hunks)
💤 Files with no reviewable changes (1)
  • .github/workflows/PR.yml
🧰 Additional context used
🪛 yamllint
recipes/libgff/meta.yaml

[error] 31-31: trailing spaces

(trailing-spaces)

🔇 Additional comments (2)
recipes/libgff/meta.yaml (2)

Line range hint 32-37: LGTM! Well-structured metadata section.

The about section follows conda packaging best practices with complete metadata including license, summary, and relevant URLs.

🧰 Tools
🪛 yamllint

[error] 31-31: trailing spaces

(trailing-spaces)


Line range hint 1-42: Verify alignment with PR objectives.

The changes in this file appear unrelated to the PR's stated objective of preventing image filename renaming in CI. Let's verify if there are other relevant files that should be reviewed.

🧰 Tools
🪛 yamllint

[error] 31-31: trailing spaces

(trailing-spaces)

recipes/libgff/meta.yaml Outdated Show resolved Hide resolved
@aliciaaevans
Copy link
Contributor Author

ok that's not going to work because it actually throws an error. Got to change it on the bioconda-utils side.

@aliciaaevans aliciaaevans reopened this Oct 28, 2024
@aliciaaevans aliciaaevans deleted the gha-image-filename branch October 29, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant